From: Phillip Potter <phil@philpotter.co.uk>
To: Martin Kaiser <martin@kaiser.cx>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Michael Straube <straube.linux@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 0/8] staging: r8188eu: another round of removals
Date: Sat, 16 Oct 2021 16:34:58 +0100 [thread overview]
Message-ID: <YWrxIllg1fMkV1/5@equinox> (raw)
In-Reply-To: <20211016113008.27549-1-martin@kaiser.cx>
On Sat, Oct 16, 2021 at 01:30:00PM +0200, Martin Kaiser wrote:
> Remove some more dead code and unused definitions.
>
> Martin Kaiser (8):
> staging: r8188eu: remove empty trigger gpio code
> staging: r8188eu: interface type is always usb
> staging: r8188eu: remove two checks that are always false
> staging: r8188eu: remove unused function prototypes
> staging: r8188eu: PHY_SetRFPathSwitch_8188E is not used
> staging: r8188eu: clean up Hal8188EPhyCfg.h
> staging: r8188eu: remove procfs functions
> staging: r8188eu: CurrentWirelessMode is not used
>
> drivers/staging/r8188eu/Makefile | 1 -
> drivers/staging/r8188eu/core/rtw_debug.c | 886 ------------------
> .../staging/r8188eu/hal/HalHWImg8188E_BB.c | 14 +-
> .../staging/r8188eu/hal/HalHWImg8188E_MAC.c | 3 +-
> .../staging/r8188eu/hal/HalHWImg8188E_RF.c | 8 +-
> drivers/staging/r8188eu/hal/HalPhyRf_8188e.c | 38 -
> drivers/staging/r8188eu/hal/odm.c | 3 -
> drivers/staging/r8188eu/hal/rtl8188e_dm.c | 2 -
> drivers/staging/r8188eu/hal/usb_halinit.c | 8 -
> .../staging/r8188eu/include/Hal8188EPhyCfg.h | 78 --
> drivers/staging/r8188eu/include/hal_intf.h | 1 -
> drivers/staging/r8188eu/include/odm.h | 11 +-
> .../staging/r8188eu/include/rtl8188e_hal.h | 1 -
> drivers/staging/r8188eu/include/rtw_debug.h | 148 ---
> 14 files changed, 6 insertions(+), 1196 deletions(-)
> delete mode 100644 drivers/staging/r8188eu/core/rtw_debug.c
>
> --
> 2.20.1
>
Dear Martin,
Looks good from what I can see, many thanks. Built and tested on my
USB-N10 Nano.
For whole series:
Acked-by: Phillip Potter <phil@philpotter.co.uk>
Regards,
Phil
next prev parent reply other threads:[~2021-10-16 15:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-16 11:30 Martin Kaiser
2021-10-16 11:30 ` [PATCH 1/8] staging: r8188eu: remove empty trigger gpio code Martin Kaiser
2021-10-17 11:23 ` Michael Straube
2021-10-16 11:30 ` [PATCH 2/8] staging: r8188eu: interface type is always usb Martin Kaiser
2021-10-17 11:46 ` Michael Straube
2021-10-16 11:30 ` [PATCH 3/8] staging: r8188eu: remove two checks that are always false Martin Kaiser
2021-10-17 11:48 ` Michael Straube
2021-10-16 11:30 ` [PATCH 4/8] staging: r8188eu: remove unused function prototypes Martin Kaiser
2021-10-17 11:50 ` Michael Straube
2021-10-16 11:30 ` [PATCH 5/8] staging: r8188eu: PHY_SetRFPathSwitch_8188E is not used Martin Kaiser
2021-10-17 11:53 ` Michael Straube
2021-10-16 11:30 ` [PATCH 6/8] staging: r8188eu: clean up Hal8188EPhyCfg.h Martin Kaiser
2021-10-17 11:54 ` Michael Straube
2021-10-16 11:30 ` [PATCH 7/8] staging: r8188eu: remove procfs functions Martin Kaiser
2021-10-17 11:56 ` Michael Straube
2021-10-16 11:30 ` [PATCH 8/8] staging: r8188eu: CurrentWirelessMode is not used Martin Kaiser
2021-10-17 11:57 ` Michael Straube
2021-10-16 15:34 ` Phillip Potter [this message]
2021-10-16 16:33 ` [PATCH 0/8] staging: r8188eu: another round of removals Martin Kaiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWrxIllg1fMkV1/5@equinox \
--to=phil@philpotter.co.uk \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®