From: Mark Brown <broonie@kernel.org>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Thierry Reding <treding@nvidia.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH v1] regulator: Don't error out fixed regulator in regulator_sync_voltage()
Date: Thu, 21 Oct 2021 15:33:37 +0100 [thread overview]
Message-ID: <YXF6QUEid6Dx1Lg4@sirena.org.uk> (raw)
In-Reply-To: <89d99367-1f69-a9b8-90ea-7f794c85d5a5@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 286 bytes --]
On Thu, Oct 21, 2021 at 04:55:17PM +0300, Dmitry Osipenko wrote:
> The alternative could be to check regulator's capabilities:
> if (!regulator_ops_is_valid(rdev, REGULATOR_CHANGE_VOLTAGE))
> return 0;
> This looks like a better variant, actually.
Yes, that should be more robust.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2021-10-21 14:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 11:07 Dmitry Osipenko
2021-10-21 13:12 ` Mark Brown
2021-10-21 13:46 ` Dmitry Osipenko
2021-10-21 13:55 ` Dmitry Osipenko
2021-10-21 14:33 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXF6QUEid6Dx1Lg4@sirena.org.uk \
--to=broonie@kernel.org \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®