From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F320BC433EF for ; Tue, 26 Oct 2021 16:46:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D8D1D60F59 for ; Tue, 26 Oct 2021 16:46:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237497AbhJZQtM (ORCPT ); Tue, 26 Oct 2021 12:49:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:49934 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237416AbhJZQtE (ORCPT ); Tue, 26 Oct 2021 12:49:04 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4ED6260F56; Tue, 26 Oct 2021 16:46:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1635266800; bh=Z3FjBer3srN93t/2Uf7lu/L5rOeofkEIMvasXqp1PmY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2Uk5IJex1IypM0jZd9RDdxc9g5l12pzKuuCnPx24gPmAxtGHu5BTSvuMH0nZOckAA 283VYCiCetAfQpyCsjk/5gnZ/yuKwW+Wh3gOQD8Qo9h17ExmFMT4CQ1EvAuIbw9rY2 RueeAztIi7APihq5SQSyFtsBSmSzPpVwLUtwF7TI= Date: Tue, 26 Oct 2021 18:46:38 +0200 From: Greg KH To: Saurav Girepunje Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, straube.linux@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, saurav.girepunje@hotmail.com Subject: Re: [PATCH v2] staging: r8188eu: avoid use of goto statement Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 25, 2021 at 08:06:00PM +0530, Saurav Girepunje wrote: > Remove the goto statement from _rtw_init_cmd_priv(). In this function > goto statement can be replace by return statement. By replacing the > goto statement with return statement local variable "res" is also not > required. As on goto label exit, function only return it is not > performing any cleanup. Avoiding goto statement will simplify the function. > > Signed-off-by: Saurav Girepunje > --- > > ChangeLog V2: > > -Add space after line end on changelog. > -Remove addition blank link after the local variable res > as per the coding guidelines for linux kernel. > This does not apply to my tree, please rebase and resubmit. thanks, greg k-h