From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B46CC433FE for ; Wed, 27 Oct 2021 11:02:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 22ED160F5A for ; Wed, 27 Oct 2021 11:02:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241574AbhJ0LFO (ORCPT ); Wed, 27 Oct 2021 07:05:14 -0400 Received: from mga17.intel.com ([192.55.52.151]:50613 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239782AbhJ0LFM (ORCPT ); Wed, 27 Oct 2021 07:05:12 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10149"; a="210914508" X-IronPort-AV: E=Sophos;i="5.87,186,1631602800"; d="scan'208";a="210914508" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2021 04:02:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,186,1631602800"; d="scan'208";a="635681271" Received: from kuha.fi.intel.com ([10.237.72.166]) by fmsmga001.fm.intel.com with SMTP; 27 Oct 2021 04:02:43 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Wed, 27 Oct 2021 14:02:42 +0300 Date: Wed, 27 Oct 2021 14:02:42 +0300 From: Heikki Krogerus To: Greg KH Cc: Prashant Malani , Benson Leung , Adam Thomson , Guenter Roeck , Badhri Jagan Sridharan , Jack Pham , "Gopal, Saranya" , "Regupathy, Rajaram" , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 0/4] USB Power Delivery character device interface Message-ID: References: <20211026143352.78387-1-heikki.krogerus@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Greg, On Tue, Oct 26, 2021 at 05:06:28PM +0200, Greg KH wrote: > So, why not sysfs? :) This is about allowing the user space to take over the USB Power Delivery communication and policy decisions in some cases. The user space needs to be able to send and receive raw USB Power Delivery messages one way or the other. I don't care about what's the interface that we use. Here we are talking about the PDOs, so basically the power contract. Even if we figured out a way how to expose all the information from the Capability, Status, Alert and what ever messages you need to the user space via sysfs, and then allow the user to separately send the Request Message, we would have only covered the power contract. That does not cover everything, but it would also be unnecessarily complicated to handle with separate sysfs files IMO. Even with the power contract it would make more sense to me to just allow the user space to simply read and write the raw messages, but when we go the other things like Vendor Specific Messages, I don't think there is any other way. So we really do need to be able to tap into the USB Power Delivery protocol layer directly from user space. I don't care about how we do that - character device is just a suggestion, although, it does still feel correct to me. Is there some other way we could do this? thanks, -- heikki