From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux ACPI <linux-acpi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH] ACPI: glue: Use acpi_device_adr() in acpi_find_child_device()
Date: Wed, 27 Oct 2021 20:35:42 +0300 [thread overview]
Message-ID: <YXmN7tnG6fddKhTJ@smile.fi.intel.com> (raw)
In-Reply-To: <CAJZ5v0j43dhVcbsKyJ8BZjeBbXHNFG-Vtv-UtsJwFBYP4usNFQ@mail.gmail.com>
On Wed, Oct 27, 2021 at 07:23:43PM +0200, Rafael J. Wysocki wrote:
> On Wed, Oct 27, 2021 at 7:17 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Wed, Oct 27, 2021 at 06:59:06PM +0200, Rafael J. Wysocki wrote:
...
> See acpi_set_pnp_ids().
>
> adev->pnp.bus_addres is the address value and
> adev->pnp.type.bus_address is a flag that is set to 1 when _ADR is
> valid.
>
> > IIUC _ADR == 0 is a valid value and children may have it like this.
>
> That's true.
>
> > I believe this change will break the working things (first comes to my mind
> > is drivers/mfd/intel_quark_i2c_gpio.c).
>
> I don't think so.
With your explanation I see where my logic is wrong. Thanks!
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-10-27 18:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 16:59 Rafael J. Wysocki
2021-10-27 17:17 ` Andy Shevchenko
2021-10-27 17:23 ` Rafael J. Wysocki
2021-10-27 17:35 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXmN7tnG6fddKhTJ@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®