From: Christoph Hellwig <hch@infradead.org>
To: Laibin Qiu <qiulaibin@huawei.com>
Cc: axboe@kernel.dk, dennis@kernel.org, tj@kernel.org,
bo.liu@linux.alibaba.com, josef@toxicpanda.com,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] blkcg: Remove extra blkcg_bio_issue_init
Date: Fri, 12 Nov 2021 00:54:00 -0800 [thread overview]
Message-ID: <YY4rqNbtVk/qud1s@infradead.org> (raw)
In-Reply-To: <20211112081006.3336263-1-qiulaibin@huawei.com>
On Fri, Nov 12, 2021 at 04:10:06PM +0800, Laibin Qiu wrote:
> if (blk_throtl_bio(bio)) {
> - blkcg_bio_issue_init(bio);
> return false;
> }
Please also drop the now superflous braces.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2021-11-12 8:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 8:10 Laibin Qiu
2021-11-12 8:54 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YY4rqNbtVk/qud1s@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=bo.liu@linux.alibaba.com \
--cc=dennis@kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qiulaibin@huawei.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®