From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Aditya Garg <gargaditya08@live.com>
Cc: Lee Jones <lee.jones@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Orlando Chamberlain <redecorating@protonmail.com>
Subject: Re: [PATCH v1 1/1] mfd: intel-lpss: Fix too early PM enablement in the ACPI ->probe()
Date: Mon, 1 Nov 2021 21:00:23 +0200 [thread overview]
Message-ID: <YYA5R6KyIYJJrUkc@smile.fi.intel.com> (raw)
In-Reply-To: <E051196A-C49B-4528-B72D-0BBC907AABFD@live.com>
On Mon, Nov 01, 2021 at 06:21:51PM +0000, Aditya Garg wrote:
> > On 01-Nov-2021, at 8:40 PM, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> >
> > The runtime PM callback may be called as soon as the runtime PM facility
> > is enabled and activated. It means that ->suspend() may be called before
> > we finish probing the device in the ACPI case. Hence, NULL pointer
> > dereference:
> >
> > intel-lpss INT34BA:00: IRQ index 0 not found
> > BUG: kernel NULL pointer dereference, address: 0000000000000030
> > ...
> > Workqueue: pm pm_runtime_work
> > RIP: 0010:intel_lpss_suspend+0xb/0x40 [intel_lpss]
> >
> > To fix this, first try to register the device and only after that enable
> > runtime PM facility.
> Following patch fixed the issue for me.
> Tested-by: Aditya Garg <gargaditya08@live.com>
Thanks for testing!
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-11-01 19:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 15:10 Andy Shevchenko
2021-11-01 18:21 ` Aditya Garg
2021-11-01 19:00 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYA5R6KyIYJJrUkc@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gargaditya08@live.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=redecorating@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®