From: "Krzysztof Wilczyński" <kw@linux.com>
To: Wan Jiabing <wanjiabing@vivo.com>
Cc: Nirmal Patel <nirmal.patel@linux.intel.com>,
Jonathan Derrick <jonathan.derrick@linux.dev>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Rob Herring <robh@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
jiabing.wan@qq.com
Subject: Re: [PATCH] PCI: vmd: Remove duplicated include in vmd.c
Date: Thu, 4 Nov 2021 12:15:50 +0100 [thread overview]
Message-ID: <YYPA5rFIqYBCek+u@rocinante> (raw)
In-Reply-To: <20211104063720.29375-1-wanjiabing@vivo.com>
Hi,
[...]
> --- a/drivers/pci/controller/vmd.c
> +++ b/drivers/pci/controller/vmd.c
> @@ -10,7 +10,6 @@
> #include <linux/irq.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> -#include <linux/device.h>
> #include <linux/msi.h>
> #include <linux/pci.h>
> #include <linux/pci-acpi.h>
Wan, thank you for reporting this!
Bjorn, the patch I sent earlier:
https://lore.kernel.org/all/20211013003145.1107148-1-kw@linux.com/
Accidentally left the include at the top that was intended to me moved to
be before the linux/msi.h to reflect previous order of the asm/device.h and
asm/msi.h had.
I must have forgotten to remove the one from the top later. Sincere
apologies!
I can send an update, or we can squeeze these two patches together. Sorry for
adding you more work to do.
Krzysztof
next prev parent reply other threads:[~2021-11-04 11:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 6:37 Wan Jiabing
2021-11-04 11:15 ` Krzysztof Wilczyński [this message]
2021-11-04 14:40 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYPA5rFIqYBCek+u@rocinante \
--to=kw@linux.com \
--cc=bhelgaas@google.com \
--cc=jiabing.wan@qq.com \
--cc=jonathan.derrick@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=nirmal.patel@linux.intel.com \
--cc=robh@kernel.org \
--cc=wanjiabing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®