From: Luis Chamberlain <mcgrof@kernel.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: hare@suse.de, hch@infradead.org, wubo40@huawei.com,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: fix bd_holder_dir kobject_create_and_add() error handling
Date: Thu, 4 Nov 2021 12:31:49 -0700 [thread overview]
Message-ID: <YYQ1Jd+F+2Cksyyt@bombadil.infradead.org> (raw)
In-Reply-To: <993a116a-72bf-9304-1577-3f2e4300daeb@kernel.dk>
On Thu, Nov 04, 2021 at 01:30:29PM -0600, Jens Axboe wrote:
> On 11/4/21 1:29 PM, Luis Chamberlain wrote:
> > Commit 83cbce957446 ("block: add error handling for device_add_disk /
> > add_disk") added error handling to device_add_disk(), however the goto
> > label for the bd_holder_dir kobject_create_and_add() failure did not set
> > the return value correctly, and so we can end up in a situation where
> > kobject_create_and_add() fails but we report success.
>
> I'm just going to fold this one in, as it's top-of-tree.
Makes sense.
Luis
prev parent reply other threads:[~2021-11-04 19:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 19:29 Luis Chamberlain
2021-11-04 19:30 ` Jens Axboe
2021-11-04 19:31 ` Luis Chamberlain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYQ1Jd+F+2Cksyyt@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wubo40@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®