From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9CDEC433FE for ; Fri, 5 Nov 2021 10:15:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA02E60EBC for ; Fri, 5 Nov 2021 10:15:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233028AbhKEKS0 (ORCPT ); Fri, 5 Nov 2021 06:18:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232693AbhKEKSY (ORCPT ); Fri, 5 Nov 2021 06:18:24 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C80FBC061714 for ; Fri, 5 Nov 2021 03:15:44 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id z11-20020a1c7e0b000000b0030db7b70b6bso9185370wmc.1 for ; Fri, 05 Nov 2021 03:15:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=akaiHjz6SwOCinQKu7wYHJykKjoOoFfBHbnijPyU0Ok=; b=bbyD9Z74N8UQc466GhZUx0314i/bxpZDkMZBSU2fESZ/OjZLFayjfO/9njpxD5Ss2U qNNUtf2eHZQ98+1gndAE/MzUGWRKyOcBin5hkvCiiBxq6kbMDsnxBAYqI2vgzj19aEfc QPXaYaTrqMQBReJcg4zOuuwJ6MFzAyXXVgCP4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=akaiHjz6SwOCinQKu7wYHJykKjoOoFfBHbnijPyU0Ok=; b=tHf7TPCP+9/Zy9QfS8wT0HqesnEJWegFCR1jDeI/BNmso+GQNpd4CZF/yTZF8nyzG4 WYxhtvNRh06pikeDsGCxRwUNXffSe/on3QE0lNVEC7G1nyiEYexJJogK1IFcSKAPzd5X dEg+fZoP9L3z8ZYDh3UnjTKIb8DAmlXdaWASZX0KuZ6WTPGgWw8h6BP1NK9oT2zwK05A ryjTbz7+oItCV+jH8H1SSfmNBsjHHBhBes5Xb3UmdFcKVtS9n1LDZj8mC/M0dP9dlDUr SdNBGSWXrau7E5jHlotl++ZYco1L+i0edAfosMxr8yztWzQ6Rbsy1vwfDHgxgP64SsVG PgrA== X-Gm-Message-State: AOAM5318pNMPlmi41XGMHnZQZ2ZRHBLip+xV/ve+XHU2A995u35oC1eh gbQF5QnMasW0DktoNi8TraEO2Q== X-Google-Smtp-Source: ABdhPJzWZ+STVhFoSz5QDe5L//xfNM8RZCNfYYtobwvhw8AXTMjQyzLb3D3WSUyjVEtEdaRStFL/+w== X-Received: by 2002:a05:600c:40b:: with SMTP id q11mr28640624wmb.185.1636107343470; Fri, 05 Nov 2021 03:15:43 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id w15sm7575820wrk.77.2021.11.05.03.15.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Nov 2021 03:15:43 -0700 (PDT) Date: Fri, 5 Nov 2021 11:15:41 +0100 From: Daniel Vetter To: Johan Hovold Cc: Dave Airlie , Sean Paul , Thomas Zimmermann , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] drm/udl: fix control-message timeout Message-ID: Mail-Followup-To: Johan Hovold , Dave Airlie , Sean Paul , Thomas Zimmermann , dri-devel@lists.freedesktop.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20211025115353.5089-1-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211025115353.5089-1-johan@kernel.org> X-Operating-System: Linux phenom 5.10.0-8-amd64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 25, 2021 at 01:53:53PM +0200, Johan Hovold wrote: > USB control-message timeouts are specified in milliseconds and should > specifically not vary with CONFIG_HZ. > > Fixes: 5320918b9a87 ("drm/udl: initial UDL driver (v4)") > Cc: stable@vger.kernel.org # 3.4 > Signed-off-by: Johan Hovold Thanks for patch, queued up for the merge window. -Daniel > --- > drivers/gpu/drm/udl/udl_connector.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/udl/udl_connector.c b/drivers/gpu/drm/udl/udl_connector.c > index 3750fd216131..930574ad2bca 100644 > --- a/drivers/gpu/drm/udl/udl_connector.c > +++ b/drivers/gpu/drm/udl/udl_connector.c > @@ -30,7 +30,7 @@ static int udl_get_edid_block(void *data, u8 *buf, unsigned int block, > int bval = (i + block * EDID_LENGTH) << 8; > ret = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0), > 0x02, (0x80 | (0x02 << 5)), bval, > - 0xA1, read_buff, 2, HZ); > + 0xA1, read_buff, 2, 1000); > if (ret < 1) { > DRM_ERROR("Read EDID byte %d failed err %x\n", i, ret); > kfree(read_buff); > -- > 2.32.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch