From: Matthew Wilcox <willy@infradead.org>
To: Ira Weiny <ira.weiny@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Prathu Baronia <prathubaronia2011@gmail.com>,
linux-kernel@vger.kernel.org, chintan.pandya@oneplus.com,
Prathu Baronia <prathu.baronia@oneplus.com>,
Thomas Gleixner <tglx@linutronix.de>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH v4 1/1] mm/highmem: Remove deprecated kmap_atomic
Date: Fri, 5 Nov 2021 17:23:11 +0000 [thread overview]
Message-ID: <YYVofyW3txoT9RLM@casper.infradead.org> (raw)
In-Reply-To: <20211105165859.GA3538886@iweiny-DESK2.sc.intel.com>
On Fri, Nov 05, 2021 at 09:58:59AM -0700, Ira Weiny wrote:
> On Fri, Nov 05, 2021 at 04:51:40PM +0000, Matthew Wilcox wrote:
> > On Fri, Nov 05, 2021 at 01:50:37PM +0000, Matthew Wilcox wrote:
> > > On Thu, Feb 11, 2021 at 03:56:25PM -0800, Andrew Morton wrote:
> > > > On Wed, 10 Feb 2021 16:33:07 -0800 Ira Weiny <ira.weiny@intel.com> wrote:
> > > >
> > > > > > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> > > > >
> > > > > This already has my signed off by so I'm not going to 'review'. With Prathu's
> > > > > testing information I hope this can land.
> > > > >
> > > > > Andrew did you see this patch?
> > > >
> > > > I did now ;)
> > > >
> > > > Tossed onto the post-rc1 pile, thanks,
> > >
> > > This patch seems to have slipped through the gaps for a couple of cycles
> > > now? I found a missed spot in it for CONFIG_HIGHMEM:
> >
> > Ugh, sorry, wrong version of the patch.
>
> Check! Yea this works for me...
>
> I think this should to through as a separate patch because Prathu's has been
> soaking for some time. No need to complicate it with this.
This isn't "complicating Prathu's patch". This is "fixing up the bit
that Prathu missed with his patch". zero_user_segments() should not
have different rules on HIGHMEM and non-HIGHMEM kernels.
next prev parent reply other threads:[~2021-11-05 17:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 7:32 [PATCH v4 0/1] " Prathu Baronia
2021-02-04 7:32 ` [PATCH v4 1/1] " Prathu Baronia
2021-02-11 0:33 ` Ira Weiny
2021-02-11 23:56 ` Andrew Morton
2021-11-05 13:49 ` Matthew Wilcox
2021-11-05 16:51 ` Matthew Wilcox
2021-11-05 16:58 ` Ira Weiny
2021-11-05 17:23 ` Matthew Wilcox [this message]
2021-11-05 18:38 ` Ira Weiny
2021-11-08 10:12 ` Prathu Baronia
2021-11-05 16:56 ` Ira Weiny
2021-11-05 17:35 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYVofyW3txoT9RLM@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=chintan.pandya@oneplus.com \
--cc=ira.weiny@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=prathu.baronia@oneplus.com \
--cc=prathubaronia2011@gmail.com \
--cc=rdunlap@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®