From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-gpio@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v5 1/1] gpio: add sloppy logic analyzer using polling
Date: Tue, 23 Nov 2021 20:47:55 +0200 [thread overview]
Message-ID: <YZ03W6UeSGxkn+Au@smile.fi.intel.com> (raw)
In-Reply-To: <YZ024q/r7Hc3TpMt@smile.fi.intel.com>
On Tue, Nov 23, 2021 at 08:45:55PM +0200, Andy Shevchenko wrote:
> On Tue, Nov 23, 2021 at 05:49:02PM +0100, Wolfram Sang wrote:
> > + # Check if we could parse something and the channel number fits
>
> > + [ "$chan" != "$elem" ] && [ "$chan" -le $max_chans ] || fail "Trigger syntax error: $elem"
>
> No need to execute `test` twice:
>
> [ "$chan" != "$elem" -a "$chan" -le $max_chans ] || fail "Trigger syntax error: $elem"
On the second thought this might be a different logic...
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-11-23 18:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 16:49 [PATCH v5 0/1] gpio: add simple " Wolfram Sang
2021-11-23 16:49 ` [PATCH v5 1/1] gpio: add sloppy " Wolfram Sang
2021-11-23 18:45 ` Andy Shevchenko
2021-11-23 18:47 ` Andy Shevchenko [this message]
2021-12-18 9:40 ` Wolfram Sang
2021-12-19 11:04 ` Andy Shevchenko
2021-12-19 13:09 ` Wolfram Sang
2021-11-24 0:35 ` Linus Walleij
2021-12-10 11:18 ` Wolfram Sang
2021-11-24 11:47 ` Bartosz Golaszewski
2021-11-24 20:12 ` Wolfram Sang
2021-11-30 10:37 ` Geert Uytterhoeven
2021-12-10 10:16 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZ03W6UeSGxkn+Au@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=corbet@lwn.net \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®