From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH 1/3] staging: zynpu: Add driver support for ARM(China) ZHOUYI AI accelerator
Date: Wed, 24 Nov 2021 08:09:10 +0100 [thread overview]
Message-ID: <YZ3lFk+7+AqSX6d3@kroah.com> (raw)
In-Reply-To: <20211124065743.421-2-caihuoqing@baidu.com>
On Wed, Nov 24, 2021 at 02:57:38PM +0800, Cai Huoqing wrote:
> ZHOUYI NPU is an AI accelerator chip which is integrated into ARM SOC,
> such as Allwinner R329 SOC.
> Add driver support for this AI accelerator here.
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
> drivers/staging/Kconfig | 2 +
> drivers/staging/Makefile | 1 +
> drivers/staging/zynpu/Kconfig | 34 +
> drivers/staging/zynpu/Makefile | 7 +
> drivers/staging/zynpu/z1.c | 233 ++++++
> drivers/staging/zynpu/z2.c | 297 ++++++++
> drivers/staging/zynpu/zhouyi.h | 70 ++
> drivers/staging/zynpu/zhouyi_base.c | 71 ++
> drivers/staging/zynpu/zynpu.h | 252 +++++++
> drivers/staging/zynpu/zynpu_core.c | 254 +++++++
> drivers/staging/zynpu/zynpu_drv.c | 349 +++++++++
> drivers/staging/zynpu/zynpu_fops.c | 245 +++++++
> drivers/staging/zynpu/zynpu_io.c | 133 ++++
> drivers/staging/zynpu/zynpu_io.h | 119 ++++
> drivers/staging/zynpu/zynpu_irq.c | 123 ++++
> drivers/staging/zynpu/zynpu_irq.h | 85 +++
> drivers/staging/zynpu/zynpu_job_manager.c | 467 +++++++++++++
> drivers/staging/zynpu/zynpu_job_manager.h | 200 ++++++
> drivers/staging/zynpu/zynpu_mm.c | 704 +++++++++++++++++++
> drivers/staging/zynpu/zynpu_mm.h | 142 ++++
> drivers/staging/zynpu/zynpu_session.c | 817 ++++++++++++++++++++++
> drivers/staging/zynpu/zynpu_session.h | 283 ++++++++
> drivers/staging/zynpu/zynpu_sysfs.c | 205 ++++++
All code added to drivers/staging/ needs a TODO file that lists what
needs to be done to get it out of the staging directory.
You do not explain in this changelog text why this code needs to go
here, and why it could just not go into the "real" part of the kernel
instead. What is wrong with it that requires it to go here?
thanks,
greg k-h
next prev parent reply other threads:[~2021-11-24 7:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 6:57 [PATCH 0/3] " Cai Huoqing
2021-11-24 6:57 ` [PATCH 1/3] " Cai Huoqing
2021-11-24 7:09 ` Greg Kroah-Hartman [this message]
2021-11-24 6:57 ` [PATCH 2/3] dt-bindings: staging: Add the binding documentation for " Cai Huoqing
2021-11-24 6:57 ` [PATCH 3/3] MAINTAINERS: Add the driver info of the " Cai Huoqing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZ3lFk+7+AqSX6d3@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=caihuoqing@baidu.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®