From: Petr Mladek <pmladek@suse.com>
To: Wander Costa <wcosta@redhat.com>
Cc: Wander Lairson Costa <wander@redhat.com>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
John Ogness <john.ogness@linutronix.de>,
open list <linux-kernel@vger.kernel.org>,
"Paul E . McKenney" <paulmck@kernel.org>
Subject: Re: [PATCH v2 1/1] printk: suppress rcu stall warnings caused by slow console devices
Date: Mon, 15 Nov 2021 11:10:01 +0100 [thread overview]
Message-ID: <YZIx+ZBEKnVHSnbO@alley> (raw)
In-Reply-To: <CAAq0SUmePQEOM2AvMfTw8zAnG3k+869wsGSMt9HvFj_wb81i0g@mail.gmail.com>
On Fri 2021-11-12 11:08:33, Wander Costa wrote:
> On Fri, Nov 12, 2021 at 5:45 AM Petr Mladek <pmladek@suse.com> wrote:
> > A workaround, is to lower console_loglevel and show only the most
> > important messages. Sometimes, a reasonable solution is to ratelimit
> > repeated messages.
> >
> > Which brings the question. What is the motivation for this patch,
> > please?
> >
> > Is it motivated by a particular bug report?
> > Or does the experience shows that this report causes more harm than
> > good?
> >
> QA has a test case in which they need to load hundreds of SCSI devices,
> and they simulate it using the scsi_debug driver:
I think that SCSI devices were the first sinner who motivated the work
on console offloading here at SUSE.
> modprobe scsi_debug virtual_gb=1 add_host=2 num_tgts=600
>
> This dumps a bunch of messages to print and the serial console driver
> cannot keep up with the data rate, causing an RCU stall. The stall is reported
> in an IRQ context, then the ring buffer flush continues from there,
> and then it causes
> a soft lockup.
I usually suggest to reduce console_loglevel as a temporary solution.
But I am not sure if it is acceptable in QA.
It might be done only around this test. I mean something like:
CONSOLE_LOGLEVEL=`cat /proc/sys/kernel/printk`
IGNORE_LOGLEVEL=`cat /sys/module/printk/parameters/ignore_loglevel`
echo "3 4 1 7" >/proc/sys/kernel/printk
echo N >/sys/module/printk/parameters/ignore_loglevel
modprobe scsi_debug virtual_gb=1 add_host=2 num_tgts=600
echo $CONSOLE_LOGLEVEL >/proc/sys/kernel/printk
echo $IGNORE_LOGLEVEL >/sys/module/printk/parameters/ignore_loglevel
Where /proc/sys/kernel/printk is a horrible interface. The first
number is important. It defines the limit used for filtering messages.
The levels are defined in include/linux/kern_levels.h.
Best Regards,
Petr
prev parent reply other threads:[~2021-11-15 10:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 19:59 [PATCH v2 0/1] printk: suppress rcu stall warnings caused by slow Wander Lairson Costa
2021-11-11 19:59 ` [PATCH v2 1/1] printk: suppress rcu stall warnings caused by slow console devices Wander Lairson Costa
2021-11-11 21:13 ` Paul E. McKenney
2021-11-11 23:28 ` kernel test robot
2021-11-11 23:33 ` kernel test robot
2021-11-12 1:41 ` Sergey Senozhatsky
2021-11-12 2:23 ` Paul E. McKenney
2021-11-12 14:42 ` Wander Costa
2021-11-12 14:57 ` Paul E. McKenney
2021-11-12 14:58 ` Wander Costa
2022-01-07 18:53 ` Paul E. McKenney
2022-01-07 20:16 ` Wander Costa
2022-01-10 11:10 ` Petr Mladek
2022-01-17 11:26 ` Wander Costa
2021-11-12 8:45 ` Petr Mladek
2021-11-12 14:08 ` Wander Costa
2021-11-15 10:10 ` Petr Mladek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZIx+ZBEKnVHSnbO@alley \
--to=pmladek@suse.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=wander@redhat.com \
--cc=wcosta@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®