From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Marco Elver <elver@google.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
Alexander Potapenko <glider@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Petr Mladek <pmladek@suse.com>,
Luis Chamberlain <mcgrof@kernel.org>,
Wei Liu <wei.liu@kernel.org>, Mike Rapoport <rppt@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
John Ogness <john.ogness@linutronix.de>,
linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com,
Alexander Popov <alex.popov@linux.com>
Subject: Re: [PATCH] panic: use error_report_end tracepoint on warnings
Date: Mon, 15 Nov 2021 16:55:17 +0200 [thread overview]
Message-ID: <YZJ01V8fZBlWz4VW@smile.fi.intel.com> (raw)
In-Reply-To: <CANpmjNMcxQ1YrvsbO-+=5vmW6rwhChjgB20FUMKvHQ9HXNwcAg@mail.gmail.com>
On Mon, Nov 15, 2021 at 03:40:24PM +0100, Marco Elver wrote:
> On Mon, 15 Nov 2021 at 15:38, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Mon, Nov 15, 2021 at 09:56:30AM +0100, Marco Elver wrote:
...
> > > ERROR_DETECTOR_KFENCE,
> > > - ERROR_DETECTOR_KASAN
> > > + ERROR_DETECTOR_KASAN,
> > > + ERROR_DETECTOR_WARN
> >
> > ...which exactly shows my point (given many times somewhere else) why comma
> > is good to have when we are not sure the item is a terminator one in the enum
> > or array of elements.
>
> So you want me to add a comma?
Yes. And you see exactly why I'm asking for that.
> (I'm not participating in bikeshedding here, just tell me what to do.)
Done!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-11-15 14:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 8:56 Marco Elver
2021-11-15 14:38 ` Andy Shevchenko
2021-11-15 14:40 ` Marco Elver
2021-11-15 14:55 ` Andy Shevchenko [this message]
2021-12-10 23:35 ` Steven Rostedt
2021-12-10 23:38 ` Marco Elver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZJ01V8fZBlWz4VW@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=alex.popov@linux.com \
--cc=arnd@arndb.de \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=john.ogness@linutronix.de \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mingo@redhat.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=rppt@kernel.org \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®