From: Mark Brown <broonie@kernel.org>
To: Adam Ward <Adam.Ward.opensource@diasemi.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Support Opensource <Support.Opensource@diasemi.com>
Subject: Re: [PATCH 1/2] DA9121: add DA914x binding info
Date: Tue, 23 Nov 2021 13:16:08 +0000 [thread overview]
Message-ID: <YZzpmPfnZ/I2ZdZk@sirena.org.uk> (raw)
In-Reply-To: <VI1PR10MB316716A5C73693A95EE120F3EC609@VI1PR10MB3167.EURPRD10.PROD.OUTLOOK.COM>
[-- Attachment #1: Type: text/plain, Size: 616 bytes --]
On Tue, Nov 23, 2021 at 01:06:23PM +0000, Adam Ward wrote:
> > On Tue, Nov 23, 2021 at 12:30PM +0000, Mark Brown wrote:
> > This is removing the existing DA9140 compatible?
> No. It's never been recognised in the driver itself and shouldn't have been there.
> Detritus from an obsolete test.
So by "no" you mean "yes" then? In any case you shouldn't be putting a
change like this in the middle of an unrelated commit without mentioning
it in the commit log, if you feel the need to remove this compatible you
should make a commit doing so. Please see submitting-patches.rst for
details on splitting changes up.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-11-23 13:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 12:19 [PATCH 0/2] regulator: da9121: add DA914x support Adam Ward
2021-11-23 12:19 ` [PATCH 1/2] DA9121: add DA914x binding info Adam Ward
2021-11-23 12:30 ` Mark Brown
2021-11-23 13:06 ` Adam Ward
2021-11-23 13:16 ` Mark Brown [this message]
2021-11-23 16:34 ` Rob Herring
2021-11-23 12:19 ` [PATCH 2/2] DA9121: add DA914x support Adam Ward
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZzpmPfnZ/I2ZdZk@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Adam.Ward.opensource@diasemi.com \
--cc=Support.Opensource@diasemi.com \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®