From: Andrew Lunn <andrew@lunn.ch>
To: Aleksander Jan Bajkowski <olek2@wp.pl>
Cc: hauke@hauke-m.de, davem@davemloft.net, kuba@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: lantiq_xrx200: increase buffer reservation
Date: Mon, 6 Dec 2021 03:10:08 +0100 [thread overview]
Message-ID: <Ya1xAHpTH72VUj35@lunn.ch> (raw)
In-Reply-To: <20211205222359.42913-1-olek2@wp.pl>
> +static inline int xrx200_max_frame_len(int mtu)
> +{
> + return VLAN_ETH_HLEN + mtu + ETH_FCS_LEN;
> +}
> +
> +static inline int xrx200_buffer_size(int mtu)
> +{
> + return round_up(xrx200_max_frame_len(mtu) - 1, 4 * XRX200_DMA_BURST_LEN);
> +}
Please don't use inline in .c files. Let the compiler decide.
Andrew
prev parent reply other threads:[~2021-12-06 2:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-05 22:23 Aleksander Jan Bajkowski
2021-12-06 2:10 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ya1xAHpTH72VUj35@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hauke@hauke-m.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olek2@wp.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®