From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: "mika.westerberg@linux.intel.com"
<mika.westerberg@linux.intel.com>,
"andy@kernel.org" <andy@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: intel: Assume 0 by default for PNP UID
Date: Tue, 7 Dec 2021 12:34:09 +0200 [thread overview]
Message-ID: <Ya84odaFgmqygJ2I@smile.fi.intel.com> (raw)
In-Reply-To: <CAAd53p7L6Wcp7wBeHRp7NDPbKJ+kPPAPXi27zWQ08jZbt3M6aA@mail.gmail.com>
On Tue, Dec 07, 2021 at 11:48:23AM +0800, Kai-Heng Feng wrote:
> On Sat, Dec 4, 2021 at 8:49 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Saturday, December 4, 2021, Kai-Heng Feng
> > <kai.heng.feng@canonical.com> wrote:
> > >
> > > There's an EHL board that the DSDT doesn't have _UID for pinctrl device,
> > > and that causes a NULL pointer dereference in strcmp().
> > >
> > > So in the absence of _UID, assume it's 0 by default to avoid the issue
> > > and get a pinmap.
> >
> > Do you have updated firmware?
>
> Customer confirmed new code drop from Intel does have _UID defined.
> So I guess this patch is not needed anymore?
It is not, this is the idea, thanks for confirming!
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-12-07 10:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-04 3:04 Kai-Heng Feng
2021-12-04 12:49 ` Andy Shevchenko
2021-12-07 3:48 ` Kai-Heng Feng
2021-12-07 10:34 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ya84odaFgmqygJ2I@smile.fi.intel.com \
--to=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=kai.heng.feng@canonical.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®