From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B5CCC433F5 for ; Wed, 1 Dec 2021 14:56:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350137AbhLAO7r (ORCPT ); Wed, 1 Dec 2021 09:59:47 -0500 Received: from mga14.intel.com ([192.55.52.115]:15254 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243151AbhLAO7l (ORCPT ); Wed, 1 Dec 2021 09:59:41 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10184"; a="236699415" X-IronPort-AV: E=Sophos;i="5.87,278,1631602800"; d="scan'208";a="236699415" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2021 06:56:03 -0800 X-IronPort-AV: E=Sophos;i="5.87,278,1631602800"; d="scan'208";a="609585890" Received: from smile.fi.intel.com ([10.237.72.184]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2021 06:56:00 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1msR0b-0011Jp-9B; Wed, 01 Dec 2021 16:54:57 +0200 Date: Wed, 1 Dec 2021 16:54:56 +0200 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Kent Gibson , Linus Walleij , Shuah Khan , Geert Uytterhoeven , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , linux-kselftest@vger.kernel.org Subject: Re: [PATCH v11 2/6] gpiolib: allow to specify the firmware node in struct gpio_chip Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 01, 2021 at 03:36:29PM +0100, Bartosz Golaszewski wrote: > On Wed, Dec 1, 2021 at 3:34 PM Andy Shevchenko > wrote: > > On Wed, Dec 01, 2021 at 04:28:19PM +0200, Andy Shevchenko wrote: > > > On Wed, Dec 01, 2021 at 02:53:42PM +0100, Bartosz Golaszewski wrote: > > > > On Wed, Dec 1, 2021 at 2:40 PM Andy Shevchenko > > > > wrote: > > > > > On Wed, Dec 01, 2021 at 02:11:28PM +0100, Bartosz Golaszewski wrote: > > > > > > On Tue, Nov 30, 2021 at 10:04 PM Bartosz Golaszewski wrote: > > > > Drop this patch and drop the line where the fwnode is assigned in > > > > gpio-sim.c. Then probe the device and print the addresses of the > > > > parent and child swnodes. See how they are the same and don't match > > > > the swnode hierarchy we created. You can then apply this patch and see > > > > how it becomes correct. > > > > > > Thanks. I will give a spin. > > > > > > Note, it seems I have to revert your older code first... > > > > Okay, I have to postpone because simple revert doesn't work for me. > > Can you clean up the next, please and I can use it starting from tomorrow? > > > > > > $ git tag --contains 5065e08e4ef3 > > DONT-USE-next-20211105 > > next-20211101 > > next-20211102 > > next-20211103 > > next-20211104 > > next-20211105 > > next-20211106 > > next-20211108 > > next-20211109 > > next-20211110 > > next-20211111 > > next-20211112 > > next-20211115 > > next-20211116 > > next-20211117 > > next-20211118 > > next-20211123 > > next-20211124 > > next-20211125 > > next-20211126 > > next-20211129 > > next-20211130 > > next-20211201 > None of this is in next, please use: > https://github.com/brgl/linux/tree/topic/gpio-sim-v12 if you want a > branch. It the old version that prevents me to apply (my branches based on next). > I just thought you were going to simply apply these patches. That's correct, but see above. Anyway, I'm already switched tasks for today. Maybe I will have some time later on. -- With Best Regards, Andy Shevchenko