From: Tejun Heo <tj@kernel.org>
To: Yu Kuai <yukuai3@huawei.com>
Cc: hch@infradead.org, axboe@kernel.dk, cgroups@vger.kernel.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
yi.zhang@huawei.com
Subject: Re: [PATCH v3 2/2] block: cancel all throttled bios in del_gendisk()
Date: Wed, 1 Dec 2021 07:01:17 -1000 [thread overview]
Message-ID: <YaeqXU82Nta+PhF6@slm.duckdns.org> (raw)
In-Reply-To: <20211201094014.330165-3-yukuai3@huawei.com>
On Wed, Dec 01, 2021 at 05:40:14PM +0800, Yu Kuai wrote:
> + /*
> + * hold queue_lock to prevent concurrent with dispatching
> + * throttled bios by timer.
> + */
> + spin_lock_irq(&q->queue_lock);
> + rcu_read_lock();
Can you see whether it still needs rcu_read_lock() while holding queue_lock?
Now that all RCU flavors are merged, I think just holding the queue_lock
should be enough here.
Looks good otherwise.
Thanks.
--
tejun
prev parent reply other threads:[~2021-12-01 17:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 9:40 [PATCH v3 0/2] " Yu Kuai
2021-12-01 9:40 ` [PATCH v3 1/2] blk-throtl: move WARN_ON_ONCE() from throtl_rb_first() to it's caller Yu Kuai
2021-12-01 9:40 ` [PATCH v3 2/2] block: cancel all throttled bios in del_gendisk() Yu Kuai
2021-12-01 17:01 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaeqXU82Nta+PhF6@slm.duckdns.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®