From: Andrew Lunn <andrew@lunn.ch>
To: Yevhen Orlov <yevhen.orlov@plvision.eu>
Cc: netdev@vger.kernel.org,
Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>,
Taras Chornyi <taras.chornyi@plvision.eu>,
Mickey Rachamim <mickeyr@marvell.com>,
Serhiy Pshyk <serhiy.pshyk@plvision.eu>,
Taras Chornyi <tchornyi@marvell.com>,
Oleksandr Mazur <oleksandr.mazur@plvision.eu>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 0/6] prestera: add basic router driver support
Date: Sat, 18 Dec 2021 17:52:55 +0100 [thread overview]
Message-ID: <Yb4R55w1mq+NXOwO@lunn.ch> (raw)
In-Reply-To: <20211217195440.29838-1-yevhen.orlov@plvision.eu>
On Fri, Dec 17, 2021 at 09:54:32PM +0200, Yevhen Orlov wrote:
> Add initial router support for Marvell Prestera driver.
> Subscribe on inetaddr notifications. TRAP packets, that has to be routed
> (if packet has router's destination MAC address).
I must be missing something here. Why do you need to tell it the IP
address in order to perform software routing? All the switch needs to
know is the MAC address. Any packets for that MAC address should be
trapped to the host. The host can then decide what to do with it,
router, bridge, or consume it itself.
> Add features:
> - Support ip address adding on port.
> e.g.: "ip address add PORT 1.1.1.1/24"
This should just work already. If it does not, you have something
wrong in your current support.
Andrew
next prev parent reply other threads:[~2021-12-18 16:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 19:54 Yevhen Orlov
2021-12-17 19:54 ` [PATCH net-next 1/6] net: marvell: prestera: add virtual router ABI Yevhen Orlov
2021-12-17 19:54 ` [PATCH net-next 2/6] net: marvell: prestera: Add router interface ABI Yevhen Orlov
2021-12-17 19:54 ` [PATCH net-next 3/6] net: marvell: prestera: Add prestera router infra Yevhen Orlov
2021-12-17 19:54 ` [PATCH net-next 4/6] net: marvell: prestera: add hardware router objects accounting Yevhen Orlov
2021-12-17 19:54 ` [PATCH net-next 5/6] net: marvell: prestera: Register inetaddr stub notifiers Yevhen Orlov
2021-12-17 21:02 ` Stephen Hemminger
2021-12-21 16:07 ` Yevhen Orlov
2021-12-17 19:54 ` [PATCH net-next 6/6] net: marvell: prestera: Implement initial inetaddr notifiers Yevhen Orlov
2021-12-17 21:03 ` Stephen Hemminger
2021-12-21 4:32 ` Yevhen Orlov
2021-12-17 21:03 ` Stephen Hemminger
2021-12-18 16:52 ` Andrew Lunn [this message]
2021-12-21 4:28 ` [PATCH net-next 0/6] prestera: add basic router driver support Yevhen Orlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yb4R55w1mq+NXOwO@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mickeyr@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=oleksandr.mazur@plvision.eu \
--cc=serhiy.pshyk@plvision.eu \
--cc=taras.chornyi@plvision.eu \
--cc=tchornyi@marvell.com \
--cc=volodymyr.mytnyk@plvision.eu \
--cc=yevhen.orlov@plvision.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®