From: Michal Hocko <mhocko@suse.com>
To: Joel Savitz <jsavitz@redhat.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"Waiman Long" <longman@redhat.com>,
linux-mm@kvack.org, "Nico Pache" <npache@redhat.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Darren Hart" <dvhart@infradead.org>,
"Davidlohr Bueso" <dave@stgolabs.net>,
"André Almeida" <andrealmeid@collabora.com>
Subject: Re: [PATCH] mm/oom_kill: wake futex waiters before annihilating victim shared mutex
Date: Thu, 9 Dec 2021 08:51:54 +0100 [thread overview]
Message-ID: <YbG1mu0CLONo+Z7l@dhcp22.suse.cz> (raw)
In-Reply-To: <CAL1p7m4ka1v-Zoi-RpDy5ME-bMikGPX5V_4Hod-Y0KHOq_G8zA@mail.gmail.com>
On Wed 08-12-21 21:59:29, Joel Savitz wrote:
> On Wed, Dec 8, 2021 at 11:05 AM Michal Hocko <mhocko@suse.com> wrote:
[...]
> > I have had a closer look and I guess I can see what you are trying to
> > achieve. futex_exit_release is normally called from exit_mm context. You
> > are likely seeing a situation when the oom victim is blocked and cannot
> > exit. That is certainly possible but it shouldn't be a permanent state.
> > So I would be more interested about your particular issue and how long
> > the task has been stuck unable to exit.
>
> Before applying this patch I never saw a task eventually exit during
> the reproduction of this system state.
What has happened to the oom victim and why it has never exited?
Side note. I have noticed that you have sent v2 with minor changes. It
is usualy better to resolve review feedback before posting a new
version. Discussion gets rather hard to follow otherwise.
Thanks!
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2021-12-09 7:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 21:49 Joel Savitz
2021-12-07 22:34 ` Joel Savitz
2021-12-07 23:47 ` Andrew Morton
2021-12-08 0:46 ` Nico Pache
2021-12-08 1:58 ` Andrew Morton
2021-12-08 3:38 ` Joel Savitz
2021-12-08 9:01 ` Michal Hocko
2021-12-08 16:05 ` Michal Hocko
2021-12-09 2:59 ` Joel Savitz
2021-12-09 7:51 ` Michal Hocko [this message]
2022-01-14 14:39 ` Joel Savitz
2022-01-14 14:55 ` Waiman Long
2022-01-14 14:58 ` Waiman Long
2022-01-17 11:33 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbG1mu0CLONo+Z7l@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=andrealmeid@collabora.com \
--cc=dave@stgolabs.net \
--cc=dvhart@infradead.org \
--cc=jsavitz@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=npache@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®