From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Yuchang Hsu <saraon640529@gmail.com>
Cc: linus.walleij@linaro.org, brgl@bgdev.pl,
Richard_Hsu@asmedia.com.tw, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, Yd_Tseng@asmedia.com.tw,
Cindy1_Hsu@asmedia.com.tw, Andrew_Su@asmedia.com.tw
Subject: Re: [PATCH v3] gpio:amdpt:add new device ID and 24-pin support
Date: Thu, 9 Dec 2021 13:18:27 +0200 [thread overview]
Message-ID: <YbHmAyVka7w814g7@smile.fi.intel.com> (raw)
In-Reply-To: <20211209022605.11250-1-Richard_Hsu@asmedia.com.tw>
On Thu, Dec 09, 2021 at 10:26:05AM +0800, Yuchang Hsu wrote:
> From: Hsu Yuchang <Richard_Hsu@asmedia.com.tw>
Thanks for v3, my comments below.
As I pointed out the subject should be
gpio: amdpt: add new device ID and 24-pin support
(mind the white spaces).
> This patch add an ACPI HID(AMDIF031) and pin number in the pt_gpio_acpi_match.
As Submitting Patches documentation advises the description should be in
imperative form:
Add an ACPI HID(AMDIF031) and pin number in the pt_gpio_acpi_match.
> And we retrieve pin number by device_get_match_data().
>
> Signed-off-by: Yuchang Hsu <Richard_Hsu@asmedia.com.tw>
> --- Add AMDIF031 support
After cutter '--- ' line means _after_, and not on the same line.
The changelog contents should explain the changes in the patch versions,
and not the changes which is done in the patch against the code base, for
the latter the commit message suffices.
Look at the plenty of the examples you may find in the mail archive:
https://lore.kernel.org/linux-gpio/.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-12-09 11:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 2:26 Yuchang Hsu
2021-12-09 11:18 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbHmAyVka7w814g7@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Andrew_Su@asmedia.com.tw \
--cc=Cindy1_Hsu@asmedia.com.tw \
--cc=Richard_Hsu@asmedia.com.tw \
--cc=Yd_Tseng@asmedia.com.tw \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=saraon640529@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®