From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Joe Perches <joe@perches.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Jean Delvare <jdelvare@suse.de>
Subject: Re: [PATCH v2 1/1] PCI: Introduce pci_bus_*() printing macros when device is not available
Date: Thu, 9 Dec 2021 21:33:40 +0200 [thread overview]
Message-ID: <YbJaFM0vlkdTwxUS@smile.fi.intel.com> (raw)
In-Reply-To: <411886e9e89f797d3f9513245f94b2a5f4a33e7d.camel@perches.com>
On Thu, Dec 09, 2021 at 10:40:57AM -0800, Joe Perches wrote:
> On Thu, 2021-12-09 at 20:27 +0200, Andy Shevchenko wrote:
...
> > +#define pci_bus_printk(level, bus, devfn, fmt, arg...) \
> > + printk(level "pci %04x:%02x:%02x.%d: " fmt, \
> > + pci_domain_nr(bus), bus->number, PCI_SLOT(devfn), PCI_FUNC(devfn), ##arg)
>
> I have a small preference for using ... and __VA_ARGS___
It contradicts what other macros in the pci.h do.
So I will stick with current solution for the sake of consistency.
...
> and likely this should have parentheses around bus
>
> printk(level "pci %04x:%02x:%02x.%d: " fmt, \
> pci_domain_nr(bus), (bus)->number, PCI_SLOT(devfn), PCI_FUNC(devfn), ##__VA_ARGS__)
This makes sense, thanks!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-12-09 19:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 18:27 Andy Shevchenko
2021-12-09 18:40 ` Joe Perches
2021-12-09 19:33 ` Andy Shevchenko [this message]
2021-12-09 19:55 ` Joe Perches
2021-12-09 20:00 ` Krzysztof Wilczyński
2021-12-09 20:13 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbJaFM0vlkdTwxUS@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=jdelvare@suse.de \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®