mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Luis Chamberlain <mcgrof@kernel.org>
To: Aaron Tomlin <atomlin@redhat.com>
Cc: Petr Mladek <pmladek@suse.com>, Christoph Lameter <cl@linux.com>,
	Miroslav Benes <mbenes@suse.cz>,
	Andrew Morton <akpm@linux-foundation.org>,
	jeyu@kernel.org, linux-kernel@vger.kernel.org,
	linux-modules@vger.kernel.org, atomlin@atomlin.com,
	ghalat@redhat.com
Subject: Re: [RFC PATCH] module: Introduce module unload taint tracking
Date: Fri, 10 Dec 2021 09:09:23 -0800	[thread overview]
Message-ID: <YbOJw4B4p7V+bfPU@bombadil.infradead.org> (raw)
In-Reply-To: <20211210160931.ftvxpulno73a2l7c@ava.usersys.com>

On Fri, Dec 10, 2021 at 04:09:31PM +0000, Aaron Tomlin wrote:
> On Fri 2021-12-10 11:00 +0100, Petr Mladek wrote:
> This is an interesting suggestion. Albeit, as per the subject, I prefer to
> just keep track of any module that tainted the kernel. That being said,
> Petr, if you'd prefer to track each module unload/or deletion event, then I
> would suggest for instance to remove a module once it has been reintroduced
> or maintain an unload count as suggested by Luis.

Come to think of this again, although at first it might be enticing to
keep track of module unloads (without taint), we have to ask ourselves
who would need / enable such a feature. And I think Aaron is right that
this might be better tracked in userspace.

The taint though, that seems critical due to the potential harm.

Maybe how many unloads one has done though, that might be useful
debugging information and does not create a huge overhead like a
pontential -ENOMEM.

  Luis

  reply	other threads:[~2021-12-10 17:09 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-24 17:33 Aaron Tomlin
2021-12-08 20:47 ` Luis Chamberlain
2021-12-09 16:49   ` Aaron Tomlin
2021-12-09 23:42     ` Luis Chamberlain
2021-12-10 10:00       ` Petr Mladek
2021-12-10 16:09         ` Aaron Tomlin
2021-12-10 17:09           ` Luis Chamberlain [this message]
2021-12-13 15:16           ` Petr Mladek
2021-12-21 11:58             ` Aaron Tomlin
2021-12-10 17:03         ` Luis Chamberlain
2021-12-10 15:48       ` Aaron Tomlin
2021-12-28 21:30       ` [RFC PATCH 00/12] module: core code clean up Aaron Tomlin
2021-12-28 21:30         ` [RFC PATCH 01/12] module: Move all into module/ Aaron Tomlin
2021-12-28 21:30         ` [RFC PATCH 02/12] module: Simple refactor in preparation for split Aaron Tomlin
2021-12-28 21:30         ` [RFC PATCH 03/12] module: Move livepatch support to a separate file Aaron Tomlin
2021-12-28 21:30         ` [RFC PATCH 04/12] module: Move latched RB-tree " Aaron Tomlin
2021-12-28 21:30         ` [RFC PATCH 05/12] module: Move arch strict rwx " Aaron Tomlin
2022-01-12 16:13           ` Luis Chamberlain
2021-12-28 21:30         ` [RFC PATCH 06/12] module: Move " Aaron Tomlin
2021-12-28 21:30         ` [RFC PATCH 07/12] module: Move extra signature support out of core code Aaron Tomlin
2021-12-28 21:30         ` [RFC PATCH 08/12] module: Move kmemleak support to a separate file Aaron Tomlin
2021-12-28 21:30         ` [RFC PATCH 09/12] module: Move kallsyms support into " Aaron Tomlin
2021-12-28 21:30         ` [RFC PATCH 10/12] module: Move procfs " Aaron Tomlin
2021-12-28 21:30         ` [RFC PATCH 11/12] module: Move sysfs " Aaron Tomlin
2022-01-12 16:20           ` Luis Chamberlain
2021-12-28 21:30         ` [RFC PATCH 12/12] module: Move kdb_modules list out of core code Aaron Tomlin
2021-12-29  8:58         ` [RFC PATCH 00/12] module: core code clean up Aaron Tomlin
2022-01-12 16:21         ` Luis Chamberlain
2021-12-13 13:00     ` [RFC PATCH] module: Introduce module unload taint tracking Allen
2021-12-20 19:23       ` Luis Chamberlain
2021-12-21 11:44       ` Aaron Tomlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YbOJw4B4p7V+bfPU@bombadil.infradead.org \
    --to=mcgrof@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=atomlin@atomlin.com \
    --cc=atomlin@redhat.com \
    --cc=cl@linux.com \
    --cc=ghalat@redhat.com \
    --cc=jeyu@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=mbenes@suse.cz \
    --cc=pmladek@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®