From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EBFBC433EF for ; Fri, 10 Dec 2021 23:00:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344783AbhLJXER (ORCPT ); Fri, 10 Dec 2021 18:04:17 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:48782 "EHLO ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239946AbhLJXEQ (ORCPT ); Fri, 10 Dec 2021 18:04:16 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 66864B82A0E; Fri, 10 Dec 2021 23:00:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5501C00446; Fri, 10 Dec 2021 23:00:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1639177238; bh=Xf3wfuPLYn/SESXVwB3nh4TuzPlgFih4NYbO3gmcg18=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PqmEu0kVkT+hrHBkWwXw69EzEtYbWKYEMBbLX9z/lY5lK0gUztiNcJSbeRhtGHmJt vuyopJNHT0DXXA0GPDRKONnHjScc+xvb9mqzaa3/KMvH9pm8xnqdvlhv4EQBAEnIdT TYgG2u+Kk43a8VbIB+bTxRg3YcT2MEapslbychbtPs2F72BnyKX1Rc4ZfdmeggvIuo WBEeQl7h6mziPSx0TGidWC4ClwJNVHOjH4JNpc4nceKYIy6PzXcw04cEgSDrDbS9ya s9Gl5gplIAtOxth+h+dVp0qrMCEmzduYdv2kgkMkFbU75r7YBw/ubk6klANRb9ukXA rWVsX4vFjeATQ== Date: Fri, 10 Dec 2021 15:00:36 -0800 From: Eric Biggers To: Linus Torvalds Cc: Alexander Viro , Benjamin LaHaise , linux-aio@kvack.org, linux-fsdevel , Linux Kernel Mailing List , Ramji Jiyani , Christoph Hellwig , Oleg Nesterov , Jens Axboe , Martijn Coenen , Xie Yongji Subject: Re: [GIT PULL] aio poll fixes for 5.16-rc5 Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 10, 2021 at 02:18:12PM -0800, Linus Torvalds wrote: > On Fri, Dec 10, 2021 at 10:33 AM Eric Biggers wrote: > > > > This has been tested with the libaio test suite, as well as with test > > programs I wrote that reproduce the first two bugs. I am sending this > > pull request myself as no one seems to be maintaining this code. > > Pulled. > > The "nobody really maintains or cares about epoll/aio" makes me wonder > if we should just remove the "if EXPERT" from the config options we > have on them, and start encouraging people to perhaps not even build > that code any more? > > Because I'm sure we have users of it, but maybe they are few enough > that saying "don't enable this feature unless you need it" is the > right thing to do... Isn't epoll more commonly used than aio? Either way, removing 'if EXPERT' from both would make sense, so that they aren't forced on just because someone didn't set CONFIG_EXPERT. I think that a lot of people have these options enabled but don't need them. Android used to be in that boat for CONFIG_AIO (i.e. it wasn't needed but was sometimes enabled anyway, maybe due to !CONFIG_EXPERT). Unfortunately Android has started depending on CONFIG_AIO, so it seems Android will need to keep it set, but I think most other Linux systems don't need it. - Eric