From: Borislav Petkov <bp@alien8.de>
To: William Roche <william.roche@oracle.com>
Cc: Yazen Ghannam <yazen.ghannam@amd.com>,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
mchehab@kernel.org, tony.luck@intel.com, james.morse@arm.com,
rric@kernel.org, Smita.KoralahalliChannabasappa@amd.com
Subject: Re: [PATCH v2 2/2] EDAC/amd64: Add new register offset support and related changes
Date: Wed, 15 Dec 2021 19:07:17 +0100 [thread overview]
Message-ID: <Ybou1VTJ8oced4Ge@zn.tnic> (raw)
In-Reply-To: <d327bbfe-a3c0-9b26-569d-43e17dba126d@oracle.com>
On Wed, Dec 15, 2021 at 05:32:27PM +0100, William Roche wrote:
> > @@ -2174,8 +2215,13 @@ static int f17_addr_mask_to_cs_size(struct amd64_pvt *pvt, u8 umc,
> > * There is one mask per DIMM, and two Chip Selects per DIMM.
> > * CS0 and CS1 -> DIMM0
> > * CS2 and CS3 -> DIMM1
> > + *
> > + * Systems with newer register layout have one mask per Chip Select.
>
> Just a question about this comment: Can it be translated into this ?
>
> + * Except on systems with newer register layout where we have one Chip Select per DIMM.
Sure, but without the "we":
...
* On systems with the newer register layout there is one Chip Select per DIMM.
*/
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2021-12-15 18:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 15:53 [PATCH v2 0/2] AMD Family 19h Models 10h-1Fh Updates Yazen Ghannam
2021-12-15 15:53 ` [PATCH v2 1/2] EDAC/amd64: Check register values from all UMCs Yazen Ghannam
2021-12-15 18:01 ` Borislav Petkov
2021-12-16 16:08 ` Yazen Ghannam
2021-12-30 11:36 ` Borislav Petkov
2022-01-05 16:12 ` Yazen Ghannam
2021-12-15 15:53 ` [PATCH v2 2/2] EDAC/amd64: Add new register offset support and related changes Yazen Ghannam
2021-12-15 16:32 ` William Roche
2021-12-15 18:07 ` Borislav Petkov [this message]
2021-12-16 15:46 ` Yazen Ghannam
2021-12-16 18:43 ` William Roche
2021-12-16 19:21 ` Yazen Ghannam
2021-12-15 17:53 ` [PATCH v2 0/2] AMD Family 19h Models 10h-1Fh Updates Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ybou1VTJ8oced4Ge@zn.tnic \
--to=bp@alien8.de \
--cc=Smita.KoralahalliChannabasappa@amd.com \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
--cc=william.roche@oracle.com \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome