From: Alan Stern <stern@rowland.harvard.edu>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: gregkh@linuxfoundation.org, mathias.nyman@linux.intel.com,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Chris Chiu <chris.chiu@canonical.com>,
Bixuan Cui <cuibixuan@huawei.com>,
Rajat Jain <rajatja@google.com>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] usb: hub: Add delay for SuperSpeed hub resume to let links transit to U0
Date: Wed, 15 Dec 2021 21:37:54 -0500 [thread overview]
Message-ID: <YbqmglqFbiTp4bkz@rowland.harvard.edu> (raw)
In-Reply-To: <CAAd53p5thAHXdmmEn9VV7nrWGu7W6UaEsB7hx7k9WYTBMG2GqQ@mail.gmail.com>
On Thu, Dec 16, 2021 at 08:23:29AM +0800, Kai-Heng Feng wrote:
> On Wed, Dec 15, 2021 at 11:47 PM Alan Stern <stern@rowland.harvard.edu> wrote:
> >
> > On Wed, Dec 15, 2021 at 08:01:06PM +0800, Kai-Heng Feng wrote:
> > > --- a/drivers/usb/core/hub.c
> > > +++ b/drivers/usb/core/hub.c
> > > @@ -1110,7 +1110,10 @@ static void hub_activate(struct usb_hub *hub, enum hub_activation_type type)
> > > } else {
> > > hub_power_on(hub, true);
> > > }
> > > - }
> > > + /* Give some time on remote wakeup to let links to transit to U0 */
> > > + } else if (hub_is_superspeed(hub->hdev))
> > > + msleep(20);
> >
> > Where did the 20-ms number come from? Is it mentioned in the spec as
> > the time required for a port to switch from U3 to U0?
>
> The 20ms is the minimal time the device take to bring link back to U0 reliably.
> The spec mentioned device has to transit the link to U0 before
> signaling remote wakeup.
> So do you think this requires a new quirk?
No, I just wondered where you got the number from. The patch looks fine; I
can't think of any reasonable way to improve it.
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Alan Stern
next prev parent reply other threads:[~2021-12-16 2:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 12:01 Kai-Heng Feng
2021-12-15 15:47 ` Alan Stern
2021-12-16 0:23 ` Kai-Heng Feng
2021-12-16 2:37 ` Alan Stern [this message]
2021-12-17 10:13 ` Chunfeng Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbqmglqFbiTp4bkz@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=Thinh.Nguyen@synopsys.com \
--cc=chris.chiu@canonical.com \
--cc=chunfeng.yun@mediatek.com \
--cc=cuibixuan@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=rajatja@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®