From: Greg KH <gregkh@linuxfoundation.org>
To: Amitay Isaacs <amitay@ozlabs.org>
Cc: linux-kernel@vger.kernel.org, linux-fsi@lists.ozlabs.org,
jk@ozlabs.org, joel@jms.id.au, alistair@popple.id.au,
eajames@linux.ibm.com
Subject: Re: [PATCH v2 2/2] fsi: sbefifo: implement FSI_SBEFIFO_READ_TIMEOUT ioctl
Date: Thu, 16 Dec 2021 09:04:45 +0100 [thread overview]
Message-ID: <YbrzHf+wRKzTFxEm@kroah.com> (raw)
In-Reply-To: <20211216062405.415888-3-amitay@ozlabs.org>
On Thu, Dec 16, 2021 at 05:24:05PM +1100, Amitay Isaacs wrote:
> FSI_SBEFIFO_READ_TIMEOUT ioctl sets the read timeout (in seconds) for
> the response received by sbefifo device from sbe. The timeout affects
> only the read operation on sbefifo device fd.
>
> Certain SBE operations can take long time to complete and the default
> timeout of 10 seconds might not be sufficient to start receiving
> response from SBE. In such cases, allow the timeout to be set to the
> maximum of 120 seconds.
>
> Signed-off-by: Amitay Isaacs <amitay@ozlabs.org>
> ---
> drivers/fsi/fsi-sbefifo.c | 44 +++++++++++++++++++++++++++++++++++++++
> include/uapi/linux/fsi.h | 14 +++++++++++++
> 2 files changed, 58 insertions(+)
Where is the userspace tool that uses this new ioctl?
And again, why does it have to be an ioctl? Where is this now
documented? What are the units of the value?
greg k-h
next prev parent reply other threads:[~2021-12-16 8:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 6:24 [PATCH v2 0/2] Enable read timeout specification for sbefifo read Amitay Isaacs
2021-12-16 6:24 ` [PATCH v2 1/2] fsi: sbefifo: Use specified value of start of response timeout Amitay Isaacs
2021-12-16 6:24 ` [PATCH v2 2/2] fsi: sbefifo: implement FSI_SBEFIFO_READ_TIMEOUT ioctl Amitay Isaacs
2021-12-16 8:04 ` Greg KH [this message]
2022-01-13 6:04 ` Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbrzHf+wRKzTFxEm@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alistair@popple.id.au \
--cc=amitay@ozlabs.org \
--cc=eajames@linux.ibm.com \
--cc=jk@ozlabs.org \
--cc=joel@jms.id.au \
--cc=linux-fsi@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®