From: Petr Mladek <pmladek@suse.com>
To: John Ogness <john.ogness@linutronix.de>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Kieran Bingham <kbingham@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts/gdb: lx-dmesg: read records individually
Date: Thu, 16 Dec 2021 15:56:23 +0100 [thread overview]
Message-ID: <YbtTl4zU4U8prj90@alley> (raw)
In-Reply-To: <874k79c3a9.fsf@jogness.linutronix.de>
On Wed 2021-12-15 16:16:22, John Ogness wrote:
> For the gdb command lx-dmesg, the entire descriptor, info, and text
> data regions are read into memory before printing any records. For
> large kernel log buffers, this not only causes a huge delay before
> seeing any records, but it may also lead to python errors of too
> much memory allocation.
>
> Rather than reading in all these regions in advance, read them as
> needed and only read the regions for the particular record that is
> being printed.
>
> The gdb macro "dmesg" in Documentation/admin-guide/kdump/gdbmacros.txt
> already prints out the kernel log buffer like this.
>
> Signed-off-by: John Ogness <john.ogness@linutronix.de>
Looks good to me.
The patch has been committed into printk/linux.git, branch for-5.17.
Best Regards,
Petr
prev parent reply other threads:[~2021-12-16 14:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 15:10 John Ogness
2021-12-16 14:56 ` Petr Mladek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbtTl4zU4U8prj90@alley \
--to=pmladek@suse.com \
--cc=jan.kiszka@siemens.com \
--cc=john.ogness@linutronix.de \
--cc=kbingham@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®