From: Greg KH <gregkh@linuxfoundation.org>
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc: jirislaby@kernel.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: Re: [PATCH v3] serial: pch_uart: potential dereference of null pointer
Date: Thu, 16 Dec 2021 16:24:36 +0100 [thread overview]
Message-ID: <YbtaNI/P6oxxWyXk@kroah.com> (raw)
In-Reply-To: <20211216150539.423387-1-jiasheng@iscas.ac.cn>
On Thu, Dec 16, 2021 at 11:05:39PM +0800, Jiasheng Jiang wrote:
> On Thu, Dec 16, 2021 at 10:36:35PM +0800, Greg KH wrote:
> >> The return value of dma_alloc_coherent() needs to be checked.
> >> To avoid dereference of null pointer in case of the failure of alloc.
> >> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
>
> >A blank line is always needed before the signed-off-by line.
>
> >> ---
> >> Changelog:
> >>
> >> v2 -> v3
> >>
> >> *Change 1. Remove dev_err.
> >> *Change 2. Change the return type of pch_request_dma to int.
> >> *Change 3. Return -ENOMEM when dma_alloc_coherent() failed and 0 the
> >> others.
> >> *Change 4. Check return value of dma_alloc_coherent().
> >
> > I see v3 here, not v4. Where is v4?
> >
> > And how did you test this change?
> >
> > thanks,
> >
> > greg k-h
>
> Sorry, I just have v3, maybe that is my fault. But I don't know why you think there is v4.
You say "change 4". Am I confused?
> And I have no idea about the "test this change"? Please give me more detail.
Did you run the kernel before your change and then after your change to
ensure that the failure you saw before your change is now properly
fixed?
How did you test this?
thanks,
greg k-h
next prev parent reply other threads:[~2021-12-16 15:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 15:05 Jiasheng Jiang
2021-12-16 15:24 ` Greg KH [this message]
2021-12-21 3:31 Jiasheng Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbtaNI/P6oxxWyXk@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jiasheng@iscas.ac.cn \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®