From: Al Viro <viro@zeniv.linux.org.uk>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: Baoquan He <bhe@redhat.com>, Vivek Goyal <vgoyal@redhat.com>,
Dave Young <dyoung@redhat.com>,
kexec@lists.infradead.org, Tiezhu Yang <yangtiezhu@loongson.cn>,
linux-kernel@vger.kernel.org,
Amit Daniel Kachhap <amit.kachhap@arm.com>,
Christoph Hellwig <hch@lst.de>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v3 0/3] Convert vmcore to use an iov_iter
Date: Sat, 1 Jan 2022 00:36:26 +0000 [thread overview]
Message-ID: <Yc+iCla9zjUFkBXt@zeniv-ca.linux.org.uk> (raw)
In-Reply-To: <20211213143927.3069508-1-willy@infradead.org>
On Mon, Dec 13, 2021 at 02:39:24PM +0000, Matthew Wilcox (Oracle) wrote:
> For some reason several people have been sending bad patches to fix
> compiler warnings in vmcore recently. Here's how it should be done.
> Compile-tested only on x86. As noted in the first patch, s390 should
> take this conversion a bit further, but I'm not inclined to do that
> work myself.
A couple of notes: please, use iov_iter_count(i) instead of open-coding
i->count. And there's a preexisting nastiness in read_vmcore() -
generally, a fault halfway through the read() is treated as a short read,
rather than -EFAULT...
next prev parent reply other threads:[~2022-01-01 0:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 14:39 Matthew Wilcox (Oracle)
2021-12-13 14:39 ` [PATCH v3 1/3] vmcore: Convert copy_oldmem_page() to take " Matthew Wilcox (Oracle)
2021-12-20 8:10 ` Baoquan He
2021-12-21 8:29 ` Christoph Hellwig
2021-12-13 14:39 ` [PATCH v3 2/3] vmcore: Convert __read_vmcore to use " Matthew Wilcox (Oracle)
2021-12-21 6:52 ` Baoquan He
2021-12-21 8:29 ` Christoph Hellwig
2021-12-13 14:39 ` [PATCH v3 3/3] vmcore: Convert read_from_oldmem() to take " Matthew Wilcox (Oracle)
2021-12-21 8:30 ` Christoph Hellwig
2021-12-16 8:43 ` [PATCH v3 0/3] Convert vmcore to use " Baoquan He
2021-12-21 8:06 ` Baoquan He
2022-01-01 0:36 ` Al Viro [this message]
2022-01-27 9:44 ` Baoquan He
2022-02-25 8:28 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yc+iCla9zjUFkBXt@zeniv-ca.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=amit.kachhap@arm.com \
--cc=bhe@redhat.com \
--cc=dyoung@redhat.com \
--cc=hch@lst.de \
--cc=kexec@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
--cc=willy@infradead.org \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®