From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Leo L. Schwab" <ewhac@ewhac.org>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Input: spaceball - fix parsing of movement data packets
Date: Thu, 30 Dec 2021 21:10:42 -0800 [thread overview]
Message-ID: <Yc6Q0tqQzHcFdlyU@google.com> (raw)
In-Reply-To: <20211221101630.1146385-1-ewhac@ewhac.org>
On Tue, Dec 21, 2021 at 02:16:31AM -0800, Leo L. Schwab wrote:
> The spaceball.c module was not properly parsing the movement reports
> coming from the device. The code read axis data as signed 16-bit
> little-endian values starting at offset 2.
>
> In fact, axis data in Spaceball movement reports are signed 16-bit
> big-endian values starting at offset 3. This was determined first by
> visually inspecting the data packets, and later verified by consulting:
> http://spacemice.org/pdf/SpaceBall_2003-3003_Protocol.pdf
>
> If this ever worked properly, it was in the time before Git...
>
> Signed-off-by: Leo L. Schwab <ewhac@ewhac.org>
Applied, thank you.
--
Dmitry
prev parent reply other threads:[~2021-12-31 5:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 10:16 Leo L. Schwab
2021-12-31 5:10 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yc6Q0tqQzHcFdlyU@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=ewhac@ewhac.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®