mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH for-stable] KVM: VMX: clear vmx_x86_ops.sync_pir_to_irr if APICv is disabled
Date: Mon, 20 Dec 2021 10:55:52 +0100	[thread overview]
Message-ID: <YcBTKJ08/7tjOBAu@kroah.com> (raw)
In-Reply-To: <20211220094950.288692-1-pbonzini@redhat.com>

On Mon, Dec 20, 2021 at 10:49:50AM +0100, Paolo Bonzini wrote:
> commit e90e51d5f01d2baae5dcce280866bbb96816e978 upstream.
> 
> There is nothing to synchronize if APICv is disabled, since neither
> other vCPUs nor assigned devices can set PIR.ON.
> 
> After the patch was committed to Linus's tree, it was observed that
> this fixes an issue with commit 7e1901f6c86c ("KVM: VMX: prepare
> sync_pir_to_irr for running with APICv disabled", backported to stable
> as e.g. commit 70a37e04c08a for the 5.15 tree).  Without this patch,
> vmx_sync_pir_to_irr can be reached with enable_apicv == false, triggering
> 
>  	if (KVM_BUG_ON(!enable_apicv, vcpu->kvm))
> 
> Fixes: 7e1901f6c86c ("KVM: VMX: prepare sync_pir_to_irr for running with APICv disabled")
> Cc: stable@vger.kernel.org
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  arch/x86/kvm/vmx/vmx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Looks like it is already queued up, thanks.

greg k-h

      reply	other threads:[~2021-12-20  9:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-20  9:49 Paolo Bonzini
2021-12-20  9:55 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YcBTKJ08/7tjOBAu@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®