From: Greg KH <gregkh@linuxfoundation.org>
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc: jirislaby@kernel.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: timbuart: Check for null res pointer
Date: Mon, 20 Dec 2021 16:40:29 +0100 [thread overview]
Message-ID: <YcCj7cj4JlCwoyhH@kroah.com> (raw)
In-Reply-To: <20211220082127.883885-1-jiasheng@iscas.ac.cn>
On Mon, Dec 20, 2021 at 04:21:27PM +0800, Jiasheng Jiang wrote:
> The return value of platform_get_resource() needs to be checked.
> To avoid use of error pointer in case that there is no suitable
> resource.
>
> Fixes: ab4382d27412 ("tty: move drivers/serial/ to drivers/tty/serial/")
No it does not. I thought I said that already.
I am going to just add your emails to a "ignore filter" for a while.
Your changes are not correct, and when asked about them, you just send
another version of the patch, which is not how to have a conversation
about a review.
good luck,
greg k-h
prev parent reply other threads:[~2021-12-20 15:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 8:21 Jiasheng Jiang
2021-12-20 13:29 ` Jiri Slaby
2021-12-20 15:40 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcCj7cj4JlCwoyhH@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jiasheng@iscas.ac.cn \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®