From: Mark Brown <broonie@kernel.org>
To: Vincent Knecht <vincent.knecht@mailoo.org>
Cc: lgirdwood@gmail.com, robh+dt@kernel.org, perex@perex.cz,
tiwai@suse.com, stephan@gerhold.net, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v2 2/2] ASoC: Add AK4375 support
Date: Tue, 21 Dec 2021 17:55:30 +0000 [thread overview]
Message-ID: <YcIVEgTOuzKRoGdh@sirena.org.uk> (raw)
In-Reply-To: <20211220193725.2650356-2-vincent.knecht@mailoo.org>
[-- Attachment #1: Type: text/plain, Size: 428 bytes --]
On Mon, Dec 20, 2021 at 08:37:25PM +0100, Vincent Knecht wrote:
> + SOC_ENUM("DACL Signal Invert", ak4375_invl_enum),
> + SOC_ENUM("DACR Signal Invert", ak4375_invr_enum),
These should really be a "DAC Signal Invert Switch" control rather than
an enum - really it's an on/off control for inversion. Other than that
the driver looks good so I'm going to go ahead and apply, please send an
incremental patch fixing this issue.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-12-21 17:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 19:37 [PATCH v2 1/2] ASoC: dt-bindings: codecs: Add bindings for ak4375 Vincent Knecht
2021-12-20 19:37 ` [PATCH v2 2/2] ASoC: Add AK4375 support Vincent Knecht
2021-12-21 17:55 ` Mark Brown [this message]
2021-12-21 19:12 ` [PATCH v2 1/2] ASoC: dt-bindings: codecs: Add bindings for ak4375 Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcIVEgTOuzKRoGdh@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=stephan@gerhold.net \
--cc=tiwai@suse.com \
--cc=vincent.knecht@mailoo.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®