mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Lai Jiangshan <jiangshanlai@gmail.com>
Cc: linux-kernel@vger.kernel.org, Lai Jiangshan <laijs@linux.alibaba.com>
Subject: Re: [PATCH 0/4] workqueue: cleanups for schedule callbacks part2
Date: Wed, 12 Jan 2022 07:47:10 -1000	[thread overview]
Message-ID: <Yd8UHnqwTm+8XhIJ@slm.duckdns.org> (raw)
In-Reply-To: <20211223123140.3789-1-jiangshanlai@gmail.com>

On Thu, Dec 23, 2021 at 08:31:36PM +0800, Lai Jiangshan wrote:
> From: Lai Jiangshan <laijs@linux.alibaba.com>
> 
> The commit 6d25be5782e4 ("sched/core, workqueues: Distangle worker
> accounting from rq lock") changed the schedule callbacks for workqueue.
> 
> It simplified the connection between scheduler and workqueue.  But it
> caused some code useless and some comments outdated in workqueue which
> needs to be cleaned up.
> 
> Patch1-3 are the cleanups based on the fact that 6d25be5782e4 changed
> to use pool lock in wq_worker_sleeping().
> 
> Patch4 is based on the fact that schedule callbacks were changed to be
> only called from schedule() which means all modification to nr_running
> is on local CPU when the worker is concurrent managed.

Applied 1-4 to wq/for-5.18. I updated the comment on the last patch.

Thanks.

-- 
tejun

      parent reply	other threads:[~2022-01-12 17:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-23 12:31 Lai Jiangshan
2021-12-23 12:31 ` [PATCH 1/4] workqueue: Remove the mb() pair between wq_worker_sleeping() and insert_work() Lai Jiangshan
2021-12-23 12:31 ` [PATCH 2/4] workqueue: Change the comments of the synchronization about the idle_list Lai Jiangshan
2021-12-23 12:31 ` [PATCH 3/4] workqueue: Use wake_up_worker() in wq_worker_sleeping() instead of open code Lai Jiangshan
2021-12-23 12:31 ` [PATCH 4/4] workqueue: Convert the type of pool->nr_running to int Lai Jiangshan
2022-01-06  9:35 ` [PATCH 0/4] workqueue: cleanups for schedule callbacks part2 Lai Jiangshan
2022-01-12 17:47 ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yd8UHnqwTm+8XhIJ@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=jiangshanlai@gmail.com \
    --cc=laijs@linux.alibaba.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®