From: Tejun Heo <tj@kernel.org>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: lizefan.x@bytedance.com, hannes@cmpxchg.org,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] cgroup: rstat: use same convention to assign cgroup_base_stat
Date: Wed, 12 Jan 2022 09:55:44 -1000 [thread overview]
Message-ID: <Yd8yQFx/cOBGd6+N@slm.duckdns.org> (raw)
In-Reply-To: <20220108003817.6619-1-richard.weiyang@gmail.com>
On Sat, Jan 08, 2022 at 12:38:16AM +0000, Wei Yang wrote:
> In function cgroup_base_stat_flush(), we update cgroup_base_stat by
> getting rstatc->bstat and adjust delta to related fields.
>
> There are two convention to assign cgroup_base_stat in this function:
>
> * rstat2 = rstat1
> * rstat2.cputime = rstat1.cputime
>
> The second convention may make audience think just field "cputime" is
> updated, while cputime is the only field in cgroup_base_stat.
>
> Let's use the same convention to eliminate this confusion.
>
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
Applied 1-2 to cgroup/for-5.18.
Thanks.
--
tejun
prev parent reply other threads:[~2022-01-12 19:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-08 0:38 Wei Yang
2022-01-08 0:38 ` [PATCH 2/2] cgroup: rstat: retrieve current bstat to delta directly Wei Yang
2022-01-12 19:55 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yd8yQFx/cOBGd6+N@slm.duckdns.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=richard.weiyang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®