From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9FEFC433EF for ; Sun, 2 Jan 2022 17:16:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229933AbiABRQb (ORCPT ); Sun, 2 Jan 2022 12:16:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229932AbiABRQ2 (ORCPT ); Sun, 2 Jan 2022 12:16:28 -0500 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11BB2C061792 for ; Sun, 2 Jan 2022 09:16:28 -0800 (PST) Received: from dslb-188-104-058-096.188.104.pools.vodafone-ip.de ([188.104.58.96] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1n44T0-0005KQ-7L; Sun, 02 Jan 2022 18:16:22 +0100 Received: from martin by martin-debian-2.paytec.ch with local (Exim 4.94.2) (envelope-from ) id 1n44Sz-000EJB-KS; Sun, 02 Jan 2022 18:16:21 +0100 Date: Sun, 2 Jan 2022 18:16:21 +0100 From: Martin Kaiser To: Michael Straube Cc: gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/7] staging: r8188eu: bTXPowerDataReadFromEEPORM is set but never used Message-ID: References: <20220101084937.3411-1-straube.linux@gmail.com> <20220101084937.3411-4-straube.linux@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220101084937.3411-4-straube.linux@gmail.com> Sender: "Martin Kaiser,,," Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thus wrote Michael Straube (straube.linux@gmail.com): > The field bTXPowerDataReadFromEEPORM of struct hal_data_8188e is set > but never used. Remove it. > Signed-off-by: Michael Straube > --- > v3: no changes > v2: no changes > drivers/staging/r8188eu/hal/rtl8188e_hal_init.c | 3 --- > drivers/staging/r8188eu/include/rtl8188e_hal.h | 1 - > 2 files changed, 4 deletions(-) > diff --git a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c > index d8d6547465a7..065c2701077d 100644 > --- a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c > +++ b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c > @@ -1127,9 +1127,6 @@ void Hal_ReadTxPowerInfo88E(struct adapter *padapter, u8 *PROMContent, bool Auto > Hal_ReadPowerValueFromPROM_8188E(&pwrInfo24G, PROMContent, AutoLoadFail); > - if (!AutoLoadFail) > - pHalData->bTXPowerDataReadFromEEPORM = true; > - > for (ch = 0; ch < CHANNEL_MAX_NUMBER; ch++) { > hal_get_chnl_group_88e(ch, &group); > diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/staging/r8188eu/include/rtl8188e_hal.h > index 8b54f52f49e2..de58c85b8bdc 100644 > --- a/drivers/staging/r8188eu/include/rtl8188e_hal.h > +++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h > @@ -180,7 +180,6 @@ struct hal_data_8188e { > u16 EEPROMSDID; > u8 EEPROMRegulatory; > - u8 bTXPowerDataReadFromEEPORM; > u8 EEPROMThermalMeter; > u8 bAPKThermalMeterIgnore; > -- > 2.34.1 Acked-by: Martin Kaiser