From: Martin Kaiser <martin@kaiser.cx>
To: Michael Straube <straube.linux@gmail.com>
Cc: gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net,
phil@philpotter.co.uk, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 5/7] staging: r8188eu: remove unused fields from struct hal_data_8188e
Date: Sun, 2 Jan 2022 18:23:59 +0100 [thread overview]
Message-ID: <YdHfrzh+DXl1g5XG@martin-debian-1.paytec.ch> (raw)
In-Reply-To: <20220101084937.3411-6-straube.linux@gmail.com>
Thus wrote Michael Straube (straube.linux@gmail.com):
> Remove unused fields from struct hal_data_8188e.
> Signed-off-by: Michael Straube <straube.linux@gmail.com>
> ---
> v3: no changes
> v2: no changes
> .../staging/r8188eu/include/rtl8188e_hal.h | 30 -------------------
> 1 file changed, 30 deletions(-)
> diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/staging/r8188eu/include/rtl8188e_hal.h
> index 40b3db34b8f2..2ce42d647a34 100644
> --- a/drivers/staging/r8188eu/include/rtl8188e_hal.h
> +++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h
> @@ -175,15 +175,9 @@ struct hal_data_8188e {
> u16 BasicRateSet;
> - /* EEPROM setting. */
> - u16 EEPROMSVID;
> - u16 EEPROMSDID;
> u8 EEPROMRegulatory;
> -
> u8 EEPROMThermalMeter;
> - bool EepromOrEfuse;
> -
> u8 Index24G_CCK_Base[RF_PATH_MAX][CHANNEL_MAX_NUMBER];
> u8 Index24G_BW40_Base[RF_PATH_MAX][CHANNEL_MAX_NUMBER];
> /* If only one tx, only BW20 and OFDM are used. */
> @@ -192,11 +186,6 @@ struct hal_data_8188e {
> s8 BW20_24G_Diff[RF_PATH_MAX][MAX_TX_COUNT];
> s8 BW40_24G_Diff[RF_PATH_MAX][MAX_TX_COUNT];
> - u8 TxPwrLevelCck[RF_PATH_MAX][CHANNEL_MAX_NUMBER];
> - /* For HT 40MHZ pwr */
> - u8 TxPwrLevelHT40_1S[RF_PATH_MAX][CHANNEL_MAX_NUMBER];
> - /* For HT 40MHZ pwr */
> - u8 TxPwrLevelHT40_2S[RF_PATH_MAX][CHANNEL_MAX_NUMBER];
> /* HT 20<->40 Pwr diff */
> u8 TxPwrHt20Diff[RF_PATH_MAX][CHANNEL_MAX_NUMBER];
> /* For HT<->legacy pwr diff */
> @@ -205,7 +194,6 @@ struct hal_data_8188e {
> u8 PwrGroupHT20[RF_PATH_MAX][CHANNEL_MAX_NUMBER];
> u8 PwrGroupHT40[RF_PATH_MAX][CHANNEL_MAX_NUMBER];
> - u8 LegacyHTTxPowerDiff;/* Legacy to HT rate power diff */
> /* The current Tx Power Level */
> u8 CurrentCckTxPwrIdx;
> u8 CurrentOfdm24GTxPwrIdx;
> @@ -213,21 +201,12 @@ struct hal_data_8188e {
> u8 CurrentBW4024GTxPwrIdx;
> /* Read/write are allow for following hardware information variables */
> - u8 framesync;
> - u32 framesyncC34;
> - u8 framesyncMonitor;
> - u8 DefaultInitialGain[4];
> u8 pwrGroupCnt;
> u32 MCSTxPowerLevelOriginalOffset[MAX_PG_GROUP][16];
> - u32 CCKTxPowerLevelOriginalOffset;
> u8 CrystalCap;
> - u32 AntennaTxPath; /* Antenna path Tx */
> - u32 AntennaRxPath; /* Antenna path Rx */
> u8 ExternalPA;
> - u8 b1x1RecvCombine; /* for 1T1R receive combining */
> -
> u32 AcParam_BE; /* Original parameter for BE, use for EDCA turbo. */
> struct bb_reg_def PHYRegDef[2]; /* Radio A/B */
> @@ -254,17 +233,9 @@ struct hal_data_8188e {
> u8 FwRsvdPageStartOffset; /* Reserve page start offset except
> * beacon in TxQ. */
> - /* 2010/08/09 MH Add CU power down mode. */
> - bool pwrdown;
> -
> u8 OutEpQueueSel;
> u8 OutEpNumber;
> - /* 2010/11/22 MH Add for slim combo debug mode selective. */
> - /* This is used for fix the drawback of CU TSMC-A/UMC-A cut.
> - * HW auto suspend ability. Close BT clock. */
> - bool SlimComboDbg;
> -
> u16 EfuseUsedBytes;
> struct P2P_PS_Offload_t p2p_ps_offload;
> @@ -280,7 +251,6 @@ struct hal_data_8188e {
> u8 C2hArray[16];
> u8 UsbTxAggMode;
> u8 UsbTxAggDescNum;
> - u32 MaxUsbRxAggBlock;
> enum usb_rx_agg_mode UsbRxAggMode;
> u8 UsbRxAggBlockCount; /* USB Block count. Block size is
> --
> 2.34.1
Acked-by: Martin Kaiser <martin@kaiser.cx>
next prev parent reply other threads:[~2022-01-02 17:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-01 8:49 [PATCH v3 0/7] staging: r8188eu: clean up " Michael Straube
2022-01-01 8:49 ` [PATCH v3 1/7] staging: r8188eu: bRDGEnable is always false Michael Straube
2022-01-02 17:02 ` Martin Kaiser
2022-01-01 8:49 ` [PATCH v3 2/7] staging: r8188eu: UsbRxHighSpeedMode is set but never used Michael Straube
2022-01-02 17:06 ` Martin Kaiser
2022-01-01 8:49 ` [PATCH v3 3/7] staging: r8188eu: bTXPowerDataReadFromEEPORM " Michael Straube
2022-01-02 17:16 ` Martin Kaiser
2022-01-01 8:49 ` [PATCH v3 4/7] staging: r8188eu: bAPKThermalMeterIgnore " Michael Straube
2022-01-02 17:17 ` Martin Kaiser
2022-01-01 8:49 ` [PATCH v3 5/7] staging: r8188eu: remove unused fields from struct hal_data_8188e Michael Straube
2022-01-02 17:23 ` Martin Kaiser [this message]
2022-01-01 8:49 ` [PATCH v3 6/7] staging: r8188eu: IntArray and C2hArray are set but never used Michael Straube
2022-01-02 17:27 ` Martin Kaiser
2022-01-01 8:49 ` [PATCH v3 7/7] staging: r8188eu: FwRsvdPageStartOffset is " Michael Straube
2022-01-02 17:28 ` Martin Kaiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdHfrzh+DXl1g5XG@martin-debian-1.paytec.ch \
--to=martin@kaiser.cx \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®