From: Christoph Hellwig <hch@infradead.org>
To: Li Zhijian <lizhijian@fujitsu.com>
Cc: zyjzyj2000@gmail.com, jgg@ziepe.ca, leon@kernel.org,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
Li Zhijian <lizhijian@cn.fujitsu.com>
Subject: Re: [PATCH v2] RDMA/rxe: Get rid of redundant plus
Date: Mon, 3 Jan 2022 23:54:04 -0800 [thread overview]
Message-ID: <YdP9HHjeA8WPiBvf@infradead.org> (raw)
In-Reply-To: <20220104012406.27580-1-lizhijian@fujitsu.com>
On Tue, Jan 04, 2022 at 09:24:06AM +0800, Li Zhijian wrote:
> --- a/drivers/infiniband/sw/rxe/rxe_opcode.c
> +++ b/drivers/infiniband/sw/rxe/rxe_opcode.c
> @@ -879,9 +879,9 @@ struct rxe_opcode_info rxe_opcode[RXE_NUM_OPCODE] = {
> [RXE_ATMETH] = RXE_BTH_BYTES
> + RXE_RDETH_BYTES
> + RXE_DETH_BYTES,
> - [RXE_PAYLOAD] = RXE_BTH_BYTES +
> + [RXE_PAYLOAD] = RXE_BTH_BYTES
> + RXE_ATMETH_BYTES
> - + RXE_DETH_BYTES +
> + + RXE_DETH_BYTES
> + RXE_RDETH_BYTES,
> }
> },
> @@ -900,9 +900,9 @@ struct rxe_opcode_info rxe_opcode[RXE_NUM_OPCODE] = {
> [RXE_ATMETH] = RXE_BTH_BYTES
> + RXE_RDETH_BYTES
> + RXE_DETH_BYTES,
> - [RXE_PAYLOAD] = RXE_BTH_BYTES +
> + [RXE_PAYLOAD] = RXE_BTH_BYTES
> + RXE_ATMETH_BYTES
> - + RXE_DETH_BYTES +
> + + RXE_DETH_BYTES
> + RXE_RDETH_BYTES,
> }
> },
Please fix this up to always have the + on the continuing line which
is the normal kernel style.
next prev parent reply other threads:[~2022-01-04 7:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 1:24 Li Zhijian
2022-01-04 2:46 ` Zhu Yanjun
2022-01-04 7:54 ` Christoph Hellwig [this message]
2022-01-04 10:38 ` lizhijian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdP9HHjeA8WPiBvf@infradead.org \
--to=hch@infradead.org \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lizhijian@cn.fujitsu.com \
--cc=lizhijian@fujitsu.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®