From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EACE9C433EF for ; Tue, 4 Jan 2022 16:10:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235176AbiADQKE (ORCPT ); Tue, 4 Jan 2022 11:10:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235151AbiADQKD (ORCPT ); Tue, 4 Jan 2022 11:10:03 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FB9CC061761 for ; Tue, 4 Jan 2022 08:10:02 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 57920B80EF3 for ; Tue, 4 Jan 2022 16:10:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1017CC36AED; Tue, 4 Jan 2022 16:09:57 +0000 (UTC) Date: Tue, 4 Jan 2022 16:09:54 +0000 From: Catalin Marinas To: Christophe Leroy Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , "alex@ghiti.fr" , "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-mm@kvack.org" , "akpm@linux-foundation.org" , "will@kernel.org" , "linux-arm-kernel@lists.infradead.org" , Steve Capper Subject: Re: [PATCH v6 03/14] mm: Add len and flags parameters to arch_get_mmap_end() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 17, 2021 at 10:27:23AM +0000, Christophe Leroy wrote: > Powerpc needs flags and len to make decision on arch_get_mmap_end(). > > So add them as parameters to arch_get_mmap_end(). > > Signed-off-by: Christophe Leroy > Cc: Steve Capper > Cc: Catalin Marinas > Cc: Will Deacon > --- > arch/arm64/include/asm/processor.h | 4 ++-- > mm/mmap.c | 6 +++--- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/arm64/include/asm/processor.h b/arch/arm64/include/asm/processor.h > index 6f41b65f9962..88c696350ace 100644 > --- a/arch/arm64/include/asm/processor.h > +++ b/arch/arm64/include/asm/processor.h > @@ -91,8 +91,8 @@ > #endif /* CONFIG_COMPAT */ > > #ifndef CONFIG_ARM64_FORCE_52BIT > -#define arch_get_mmap_end(addr) ((addr > DEFAULT_MAP_WINDOW) ? TASK_SIZE :\ > - DEFAULT_MAP_WINDOW) > +#define arch_get_mmap_end(addr, len, flags) ((addr > DEFAULT_MAP_WINDOW) ? TASK_SIZE :\ > + DEFAULT_MAP_WINDOW) Nitpick, move the "((addr > ...." on the following line. Either way, Acked-by: Catalin Marinas