From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Miaoqian Lin <linmq006@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandru Ardelean <ardeleanalex@gmail.com>,
Stephan Gerhold <stephan@gerhold.net>,
Gwendal Grignou <gwendal@chromium.org>,
Adriana Reus <adi.reus@gmail.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: gyro: bmg160: Fix error handling in bmg160_core_probe
Date: Wed, 5 Jan 2022 15:54:37 +0200 [thread overview]
Message-ID: <YdWjHWowWXy01zaE@smile.fi.intel.com> (raw)
In-Reply-To: <20220105125633.21989-1-linmq006@gmail.com>
On Wed, Jan 05, 2022 at 12:56:30PM +0000, Miaoqian Lin wrote:
> The pm_runtime_enable will increase power disable depth.
> If the probe fails, we should use pm_runtime_disable() to balance
> pm_runtime_enable(). In the PM Runtime docs:
> Drivers in ->remove() callback should undo the runtime PM changes done
> in ->probe(). Usually this means calling pm_runtime_disable(),
> pm_runtime_dont_use_autosuspend() etc.
> We should do this in error handling.
Looking into culprit commit, can you fix all of them, please?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-01-05 14:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 12:56 Miaoqian Lin
2022-01-05 13:07 ` Jonathan Cameron
2022-01-05 13:52 ` Andy Shevchenko
2022-01-05 13:54 ` Andy Shevchenko [this message]
2022-01-06 11:23 ` [PATCH v2] iio: Fix error handling for PM Miaoqian Lin
2022-01-07 11:59 ` Andy Shevchenko
2022-01-30 14:51 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdWjHWowWXy01zaE@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=adi.reus@gmail.com \
--cc=ardeleanalex@gmail.com \
--cc=gwendal@chromium.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linmq006@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®