From: "Theodore Ts'o" <tytso@mit.edu>
To: cgel.zte@gmail.com
Cc: Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
luo penghao <luo.penghao@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>,
Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Subject: Re: [PATCH v2] ext4: Remove unnecessary assignments
Date: Wed, 5 Jan 2022 18:24:36 -0500 [thread overview]
Message-ID: <YdYotAyQqQgI+Oo+@mit.edu> (raw)
In-Reply-To: <20211104063637.2842-1-luo.penghao@zte.com>
On Thu, Nov 04, 2021 at 06:36:37AM +0000, cgel.zte@gmail.com wrote:
> From: luo penghao <luo.penghao@zte.com.cn>
>
> The assignment at the end of the function is not necessary
>
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 089c958..f1258a7 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -3886,7 +3886,7 @@ void ext4_mb_mark_bb(struct super_block *sb, ext4_fsblk_t block,
> if (err)
> goto out_err;
> sync_dirty_buffer(bitmap_bh);
> - err = ext4_handle_dirty_metadata(NULL, NULL, gdp_bh);
> + ext4_handle_dirty_metadata(NULL, NULL, gdp_bh);
> sync_dirty_buffer(gdp_bh);
>
> out_err:
There's actually a bigger issue here than the Clang analyzer
complaining about the unnecessasary assignment --- and that is we
*should* be propagating the error up to ext4_mb_mark_bb's callers, and
those callers should be logging errors and potentially aborting the
fast_commit replay.
There might be some errors that can be ignored, if an idempotent
operation doesn't need to be redone. However, in cases like
ext4_handle_dirty_metadata(), or ext4_read_block_bitmap(), any
failures are probably due to something fatal happening --- either an
ENOMEM, or an I/O error, etc., and simply silently aborting the
current function without logging any kind of problem is going to make
it much harder to root cause a potential fast commit replay failure.
So what we should probably do is make ext4_mb_mark_bb return an error,
and then we'll need to look at all of the callers of ext4_mb_mark_bb,
and fix them up as necessary.
- Ted
prev parent reply other threads:[~2022-01-05 23:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 6:36 cgel.zte
2022-01-05 23:24 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdYotAyQqQgI+Oo+@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=cgel.zte@gmail.com \
--cc=harshadshirwadkar@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luo.penghao@zte.com.cn \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®