From: Mark Brown <broonie@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>,
Lee Jones <lee.jones@linaro.org>, Arnd Bergmann <arnd@arndb.de>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: debugfs: Directory with parent 'regmap' already present!
Date: Thu, 6 Jan 2022 17:24:49 +0000 [thread overview]
Message-ID: <Ydcl4bkdxco1UeuI@sirena.org.uk> (raw)
In-Reply-To: <CAOMZO5A4292S216dPE2CwKwa6tRoWaGfXfJh6rVJTNWk8r1ZdA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 512 bytes --]
On Thu, Jan 06, 2022 at 01:57:15PM -0300, Fabio Estevam wrote:
> On Thu, Jan 6, 2022 at 9:07 AM Mark Brown <broonie@kernel.org> wrote:
> The duplicate "dummy-iomuxc-gpr@20e0000" comes from the lack of doing
> a kfree(map->debugfs_name);
>
> Calling 'kfree(map->debugfs_name);' like this:
That doesn't sound like a good idea - if this does anything we must be
looking at the data so only adding frees will only translate using the
wrong data into a dereference of a freed pointer which seems worse.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2022-01-06 17:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-06 11:47 Fabio Estevam
2022-01-06 12:07 ` Mark Brown
2022-01-06 16:57 ` Fabio Estevam
2022-01-06 17:24 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ydcl4bkdxco1UeuI@sirena.org.uk \
--to=broonie@kernel.org \
--cc=arnd@arndb.de \
--cc=festevam@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.schiffer@ew.tq-group.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®