From: "Gabriel L. Somlo" <gsomlo@gmail.com>
To: Hillf Danton <hdanton@sina.com>
Cc: linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
Kamil Rakoczy <krakoczy@antmicro.com>,
Maciej Dudek <mdudek@internships.antmicro.com>,
Paul Mackerras <paulus@ozlabs.org>,
rdunlap@infradead.org, andy.shevchenko@gmail.com
Subject: Re: [PATCH v9 3/3] mmc: Add driver for LiteX's LiteSDCard interface
Date: Sat, 8 Jan 2022 23:19:05 -0500 [thread overview]
Message-ID: <YdpiOaJLJN7lOadu@glsvmlin.ini.cmu.edu> (raw)
In-Reply-To: <20220109025042.1537-1-hdanton@sina.com>
On Sun, Jan 09, 2022 at 10:50:42AM +0800, Hillf Danton wrote:
> On Sat, 8 Jan 2022 11:11:34 -0500 Gabriel Somlo wrote:
> > +
> > + /* LiteSDCard can support 64-bit DMA addressing */
> > + ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));
> > + if (ret)
> > + return ret;
> > +
> > + host->buf_size = mmc->max_req_size * 2;
> > + host->buffer = dmam_alloc_coherent(dev, host->buf_size,
> > + &host->dma, GFP_DMA);
>
> GFP_DMA can not make much sence given the above comment.
I'll change it to GFP_KERNEL in v10. Thanks for catching that,
--Gabriel
prev parent reply other threads:[~2022-01-09 4:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-08 16:11 [PATCH v9 0/3] mmc: Add LiteSDCard mmc driver Gabriel Somlo
2022-01-08 16:11 ` [PATCH v9 1/3] MAINTAINERS: co-maintain LiteX platform Gabriel Somlo
2022-01-08 16:11 ` [PATCH v9 2/3] dt-bindings: mmc: Add bindings for LiteSDCard Gabriel Somlo
2022-01-08 16:11 ` [PATCH v9 3/3] mmc: Add driver for LiteX's LiteSDCard interface Gabriel Somlo
2022-01-08 17:43 ` Andy Shevchenko
2022-01-09 0:26 ` Gabriel L. Somlo
2022-01-09 11:43 ` Andy Shevchenko
2022-01-10 8:25 ` Geert Uytterhoeven
[not found] ` <20220109025042.1537-1-hdanton@sina.com>
2022-01-09 4:19 ` Gabriel L. Somlo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdpiOaJLJN7lOadu@glsvmlin.ini.cmu.edu \
--to=gsomlo@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=hdanton@sina.com \
--cc=krakoczy@antmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mdudek@internships.antmicro.com \
--cc=paulus@ozlabs.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®