From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46F14C43219 for ; Tue, 25 Jan 2022 03:15:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1318725AbiAYDG5 (ORCPT ); Mon, 24 Jan 2022 22:06:57 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:52124 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346056AbiAYB6d (ORCPT ); Mon, 24 Jan 2022 20:58:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=vqIncw13EOORmlT/EjoC9h1eW7p1pLa1zW6wJTH4hys=; b=LehDvF77PFOcpCL1ZlaeFDIvoy 6kdNcCdYavZY8+3gy+TB/K/Slen/OnLNJCdIHkF7MpikmyoRpea9BKbbuLu7UvV/xH51qrjZT5bPI 7A3Myt6wLQLzABqOIHDH4s9Ex/dkrmxmsX6tYe7qKv8CxnoWENvJ1DZrsmCCWydCODNk=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nCAhM-002ZLq-HM; Tue, 25 Jan 2022 02:32:40 +0100 Date: Tue, 25 Jan 2022 02:32:40 +0100 From: Andrew Lunn To: "Ismail, Mohammad Athari" Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Jakub Kicinski , Maxime Coquelin , "Ong, Boon Leong" , "Voon, Weifeng" , "Wong, Vee Khee" , Huacai Chen , "netdev@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH net 2/2] net: stmmac: skip only stmmac_ptp_register when resume from suspend Message-ID: References: <20220124095951.23845-1-mohammad.athari.ismail@intel.com> <20220124095951.23845-3-mohammad.athari.ismail@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > > @@ -3308,13 +3309,11 @@ static int stmmac_hw_setup(struct net_device > > *dev, bool init_ptp) ... > > The init_ptp parameter now seems unused? If so, please remove it. > > I believe you miss below diff. It is renamed to ptp_register. Ah, yes, sorry. I was looking at the context information diff gives you, which still has the old name. Andrew