From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>,
Watson Chow <watson.chow@avnet.com>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH] regulator: MAX20086: add gpio/consumer.h
Date: Sat, 15 Jan 2022 18:31:08 +0200 [thread overview]
Message-ID: <YeL2zLp9jsbBqMYG@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20220115033603.24473-1-rdunlap@infradead.org>
Hi Randy,
Thank you for the patch.
On Fri, Jan 14, 2022 at 07:36:03PM -0800, Randy Dunlap wrote:
> max20086-regulator.c needs <linux/gpio/consumer.h> for an enum, some
> macros, and a function prototype. (seen on ARCH=m68k)
>
> Adding this header file fixes multiple build errors:
>
> ../drivers/regulator/max20086-regulator.c: In function 'max20086_i2c_probe':
> ../drivers/regulator/max20086-regulator.c:217:26: error: storage size of 'flags' isn't known
> 217 | enum gpiod_flags flags;
> ../drivers/regulator/max20086-regulator.c:261:27: error: 'GPIOD_OUT_HIGH' undeclared (first use in this function); did you mean 'GPIOF_INIT_HIGH'?
> 261 | flags = boot_on ? GPIOD_OUT_HIGH : GPIOD_OUT_LOW;
> | ^~~~~~~~~~~~~~
> ../drivers/regulator/max20086-regulator.c:261:44: error: 'GPIOD_OUT_LOW' undeclared (first use in this function); did you mean 'GPIOF_INIT_LOW'?
> 261 | flags = boot_on ? GPIOD_OUT_HIGH : GPIOD_OUT_LOW;
> ../drivers/regulator/max20086-regulator.c:262:27: error: implicit declaration of function 'devm_gpiod_get'; did you mean 'devm_gpio_free'? [-Werror=implicit-function-declaration]
> 262 | chip->ena_gpiod = devm_gpiod_get(chip->dev, "enable", flags);
> ../drivers/regulator/max20086-regulator.c:217:26: warning: unused variable 'flags' [-Wunused-variable]
> 217 | enum gpiod_flags flags;
>
> Fixes: bfff546aae50 ("regulator: Add MAX20086-MAX20089 driver")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Watson Chow <watson.chow@avnet.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/regulator/max20086-regulator.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20220114.orig/drivers/regulator/max20086-regulator.c
> +++ linux-next-20220114/drivers/regulator/max20086-regulator.c
> @@ -7,6 +7,7 @@
>
> #include <linux/err.h>
> #include <linux/gpio.h>
> +#include <linux/gpio/consumer.h>
> #include <linux/i2c.h>
> #include <linux/module.h>
> #include <linux/regmap.h>
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2022-01-15 16:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-15 3:36 Randy Dunlap
2022-01-15 16:31 ` Laurent Pinchart [this message]
2022-01-19 18:02 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YeL2zLp9jsbBqMYG@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=rdunlap@infradead.org \
--cc=watson.chow@avnet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®