From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC3E3C4332F for ; Mon, 17 Jan 2022 09:23:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235609AbiAQJXc (ORCPT ); Mon, 17 Jan 2022 04:23:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233941AbiAQJXb (ORCPT ); Mon, 17 Jan 2022 04:23:31 -0500 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 521DAC06173F for ; Mon, 17 Jan 2022 01:23:31 -0800 (PST) Received: by mail-lf1-x12a.google.com with SMTP id o12so38481186lfu.12 for ; Mon, 17 Jan 2022 01:23:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech-se.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=k0cfcD39y/3sDNQaa30NikkTggeMzy9AFVo7QaPEGY8=; b=zN7iolHQDgeWpC9OIhg9O5pif9q1PmcrogDzuDQPCXnVG8Aj6+uZVBD4Ck85XTIVYd A+nUdoA8YUqvC2d7ZqrfWUi1GW7agod+xmVhGP69PKaH+sWNyV2qeE+mIzAy4uZ7bM1G otdQdee9jUucSngD9djwupvyYuDvU0gRjf3k0LN6keNSXzSIXXEZTjb+LNCe0Yc+ZmOt /PZvRMDqUgTJBkWKTnGBw5xRPfDrT0srdkFJhvGiVofwcDtYlIww9icseWmMbk9cUTLu F3AWGAYoU0yP09U2Yc+cx4WeA+fYS7YPpAySHhccK5rzpuzX5aifcIwXfHyo4YZ538vm Xtfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=k0cfcD39y/3sDNQaa30NikkTggeMzy9AFVo7QaPEGY8=; b=Q5aE6+GMgegGf3oevHbOoXBEPLiyKypnr9uufPgI3MKOzcamla87vdMWdsbFlvVbA3 GIDm9AXx5sAJYu/eWC/CuCMVQY5L3DJtMf1iRXelgJeJUin4BrTXl8Db8qFJuFx6hv3j kaHh3eX/X2Ah3xdq324cZ/3uW+xPiTcI+oKbf4+MaCTeYoqtqBJy561ZGJtUCuCBXu3r RBH6f+auNYaYTqth4qj+lQIyt/jnTJhcDlnl8BcL3wOS12MrRN7DNQw/Q8k7uHNLXryN w1AA+p0aoSbBJSg8+K4L19DJ7efFhd13khJJ2vQaUzCyuCh9qGGvlvkwM6sxNcdkS3K4 afMA== X-Gm-Message-State: AOAM5300gqshp0OSz8+AQPcqp3H1m4pBAwDzvOmDzosWhpIzJgSm8Orv l8B3Y9POSJlgw4GcokOD4f/jGQ== X-Google-Smtp-Source: ABdhPJzP68J0q8Zi3yeJQsgD0w1S5UKKr27gp4K3ZswRT06lTANaZdjqeTtT1emEMZIU1BPEle/Nrg== X-Received: by 2002:a05:6512:1597:: with SMTP id bp23mr15225015lfb.572.1642411409521; Mon, 17 Jan 2022 01:23:29 -0800 (PST) Received: from localhost (h-85-24-188-65.A463.priv.bahnhof.se. [85.24.188.65]) by smtp.gmail.com with ESMTPSA id i36sm1334556lfv.201.2022.01.17.01.23.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jan 2022 01:23:29 -0800 (PST) Date: Mon, 17 Jan 2022 10:23:28 +0100 From: Niklas =?iso-8859-1?Q?S=F6derlund?= To: Jacopo Mondi Cc: Lad Prabhakar , Mauro Carvalho Chehab , Rob Herring , Geert Uytterhoeven , Prabhakar , Biju Das , linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: dt-bindings: media: renesas,csi2: Update data-lanes property Message-ID: References: <20220113103215.27080-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20220117081110.bkwr3ttoexgr2wjt@uno.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220117081110.bkwr3ttoexgr2wjt@uno.localdomain> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Jacopo, On 2022-01-17 09:11:10 +0100, Jacopo Mondi wrote: > Hello Prabhakar, > > On Thu, Jan 13, 2022 at 10:32:14AM +0000, Lad Prabhakar wrote: > > CSI-2 (CSI4LNK0) on R-Car and RZ/G2 supports 4-lane mode which is already > > handled by rcar-csi2.c driver. This patch updates the data-lanes property > > to describe the same. > > > > Signed-off-by: Lad Prabhakar > > --- > > .../devicetree/bindings/media/renesas,csi2.yaml | 9 ++++++++- > > 1 file changed, 8 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/media/renesas,csi2.yaml b/Documentation/devicetree/bindings/media/renesas,csi2.yaml > > index e6a036721082..064a0a4c5737 100644 > > --- a/Documentation/devicetree/bindings/media/renesas,csi2.yaml > > +++ b/Documentation/devicetree/bindings/media/renesas,csi2.yaml > > @@ -67,7 +67,14 @@ properties: > > maxItems: 1 > > > > data-lanes: > > - maxItems: 1 > > + items: > > + minItems: 1 > > + maxItems: 4 > > + items: > > + - const: 1 > > + - const: 2 > > + - const: 3 > > + - const: 4 > > Seeing "maxItems: 1" there confuses me too, as the property is an > array of data-lanes, but I'm afraid your change does not what you > intend as it would allow you to specify the number of data lanes as an > integer rather than as an array. > > I think it would probably be correct to set > > data-lanes: true > > (maybe maxItems: 1 is correct already) > > And restrict the number of valid combinations in the board DTS file > with a construct like: > > data-lanes: > oneOf: > - items: > - const: 1 > - const: 2 > - const: 3 > - const: 4 > - items: > - const: 1 > - const: 2 I don't think this is correct, what if data lanes 2 and 3 are used? > > Thanks > j > > > > > required: > > - clock-lanes > > -- > > 2.17.1 > > -- Kind Regards, Niklas Söderlund