From: Greg KH <gregkh@linuxfoundation.org>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: stern@rowland.harvard.edu, mathias.nyman@linux.intel.com,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Bixuan Cui <cuibixuan@huawei.com>,
Rajat Jain <rajatja@google.com>, Andrew Lunn <andrew@lunn.ch>,
Chris Chiu <chris.chiu@canonical.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] usb: core: Bail out when port is stuck in reset loop
Date: Mon, 17 Jan 2022 08:18:53 +0100 [thread overview]
Message-ID: <YeUYXbIsZV1GY3wa@kroah.com> (raw)
In-Reply-To: <CAAd53p6ev+yQT+jf32UrTMWQXwDPYtmZSrW0zCQnKuUaBbtXUg@mail.gmail.com>
On Mon, Jan 17, 2022 at 11:00:05AM +0800, Kai-Heng Feng wrote:
> On Thu, Dec 30, 2021 at 1:28 PM Kai-Heng Feng
> <kai.heng.feng@canonical.com> wrote:
> >
> > Unplugging USB device may cause an incorrect warm reset loop and the
> > port can no longer be used:
> > [ 143.039019] xhci_hcd 0000:00:14.0: Port change event, 2-3, id 19, portsc: 0x4202c0
> > [ 143.039025] xhci_hcd 0000:00:14.0: handle_port_status: starting usb2 port polling.
> > [ 143.039051] hub 2-0:1.0: state 7 ports 10 chg 0000 evt 0008
> > [ 143.039058] xhci_hcd 0000:00:14.0: Get port status 2-3 read: 0x4202c0, return 0x4102c0
> > [ 143.039092] xhci_hcd 0000:00:14.0: clear port3 connect change, portsc: 0x4002c0
> > [ 143.039096] usb usb2-port3: link state change
> > [ 143.039099] xhci_hcd 0000:00:14.0: clear port3 link state change, portsc: 0x2c0
> > [ 143.039101] usb usb2-port3: do warm reset
> > [ 143.096736] xhci_hcd 0000:00:14.0: Get port status 2-3 read: 0x2b0, return 0x2b0
> > [ 143.096751] usb usb2-port3: not warm reset yet, waiting 50ms
> > [ 143.131500] xhci_hcd 0000:00:14.0: Can't queue urb, port error, link inactive
> > [ 143.138260] xhci_hcd 0000:00:14.0: Port change event, 2-3, id 19, portsc: 0x2802a0
> > [ 143.138263] xhci_hcd 0000:00:14.0: handle_port_status: starting usb2 port polling.
> > [ 143.160756] xhci_hcd 0000:00:14.0: Get port status 2-3 read: 0x2802a0, return 0x3002a0
> > [ 143.160798] usb usb2-port3: not warm reset yet, waiting 200ms
> >
> > The port status is PP=1, CCS=0, PED=0, PLS=Inactive, which is Error
> > state per "USB3 Root Hub Port State Machine". It's reasonable to perform
> > warm reset several times, but if the port is still not enabled after
> > many attempts, consider it's gone and treat it as disconnected.
> >
> > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
>
> A gentle ping...
It's the merge window, I can't do anything, sorry. Please wait until
after 5.17-rc1 is out.
thanks,
greg k-h
next prev parent reply other threads:[~2022-01-17 7:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-30 5:28 Kai-Heng Feng
2022-01-17 3:00 ` Kai-Heng Feng
2022-01-17 7:18 ` Greg KH [this message]
2022-01-17 16:10 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YeUYXbIsZV1GY3wa@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=andrew@lunn.ch \
--cc=chris.chiu@canonical.com \
--cc=cuibixuan@huawei.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=rajatja@google.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome